469023 - network.protocol-handler.warn-external-default does not work with hildon platform

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Add missing default action check

set
pref("network.protocol-handler.warn-external-default", false);
in preferences.

open URL

EXPECTED:
Email application is opened

ACTUAL:
nsContentDispatcher dialog opened and asking to choose application.

Comment 1

[Oleg Romashin (:romaxa)]

Fix URL, and assign to myself

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 352428 [details] [diff] [review]
Add missing default action check

does the compiler actually complain if you mark nsMIMEInfoUnix::HandlerExists static both in the cpp file and in the header as static?  Mostly curious.

does hildon_uri_action_unref accept NULL as input?  (should the unref be also under the if(action) branch?

If we don't crash when action is NULL, r=me.

Comment 3

[timeless]

such questions can be answered by using:
http://mxr.maemo.org/diablo/ident?i=hildon_uri_action_unref

http://mxr.maemo.org/diablo/source/libhildonmime-2.0.2/libhildonmime/hildon-uri.c?mark=1382-1384#1382

Comment 4

[Oleg Romashin (:romaxa)]

(In reply to comment #2)
> (From update of attachment 352428 [details] [diff] [review])
> does the compiler actually complain if you mark nsMIMEInfoUnix::HandlerExists
> static both in the cpp file and in the header as static?  Mostly curious.
I'll remove static from cpp

> 
> does hildon_uri_action_unref accept NULL as input?
g_set_error will not do anything in this case.
>  (should the unref be also
> under the if(action) branch?

That is good idea.

> 
> If we don't crash when action is NULL, r=me.
No it does not crash

Comment 5

[Oleg Romashin (:romaxa)]

Oh, static in cpp is commented /* static */

Comment 6

[Oleg Romashin (:romaxa)]

Fixed in:
http://hg.mozilla.org/mozilla-central/rev/6c47449be33d