469102 - Places Tag Autocomplete breaks with certain tags (Regex escaping)

Status: VERIFIED FIXED

(Toolkit :: Places, defect, P2)

Description

[Thomas Stache]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20081210 Firefox/3.0.4
Build Identifier: 

I seem to have a tag that breaks the autocomplete (I was very surprised to see
the bug 415960 being marked "fixed 1.9.1", as I've never seen any tag autocompletion).

Reproducible: Always

Steps to Reproduce:
1. Tag a page with "c++", additional tags should be stored to have something to autocomplete...
2. Try to edit tags for any bookmark, e.g. in Library or the dialog invoked from a bookmark's "Properties..." context menu entry.
3. No tag autocompletion appears...



Error in the Error Console:

Error: invalid quantifier +$|c++(,|;))
Source File: file:/// ... /components/nsTaggingService.js
Line: 490

The string "c++" is one of my tags, it seems to be built into a regex, which is hence rendered invalid.

about:buildconfig:
Built from http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9269759f81b7

Comment 1

[Thomas Stache]

Note that I use a user agent override, I did not really use "Firefox 3.0.4", as Bugzilla claims.

Comment 2

[Marco Bonardo [:mak]]

confirmed on latest trunk

Comment 3

[Dietrich Ayala (:dietrich)]

drivers: this easily breaks tag autocomplete, and should be a very low risk fix. requesting blocking.

Comment 4

[Dietrich Ayala (:dietrich)]

Attachment: v1

removed regexp entirely. this should be faster as well.

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 353543 [details] [diff] [review]
v1

r=mak77

Comment 6

[Dietrich Ayala (:dietrich)]

http://hg.mozilla.org/mozilla-central/rev/ea93a49fd65d

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20081222 Minefield/3.2a1pre ID:20081222020443

Looks like everything is ok with the patch. Can we get it into the 1.9.1 branch?

Comment 8

[Marco Bonardo [:mak]]

(In reply to comment #7)
> Looks like everything is ok with the patch. Can we get it into the 1.9.1
> branch?

i'll push a bundle of current approved Places patches to 1.9.1 most likely tomorrow.

Comment 9

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4e2faabbc3f0

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified on 1.9.1 with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20081224 Shiretoko/3.1b3pre ID:20081224020421

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081224 Shiretoko/3.1b3pre ID:20081224042714