The font size is too small with the Classic skin (especially in bug comments)

RESOLVED FIXED in Bugzilla 3.2

Status

()

defect
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: graeme, Assigned: LpSolit)

Tracking

({regression})

Bug Flags:
approval +
approval3.2 +

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Build Identifier: 3.2

When using IE (v6 - on XPSP3) the comments (on show_bug.cgi) and the mail addresses listed (in process_bug.cgi after a change is made to a bug) are much smaller than in versions prior to v3.2. The fonts are in the region of 8pt size which makes them hard to read when using standard display sizes in IE. Fonts display fine in the new Dusk skin, and look fine in Firefox3 too. 

Adding the following to IE-fixes.css (in skins/custom) seems to make the relevant text much easier to read:

div#bugzilla-body dl dd dl dd {
_font-size: 1.1em;
}

.bz_comment_text {
_font-size: 1.1em;
}

There may well be other areas that I haven't noticed (or had users complain about - I use Firefox so it's not noticable to me).


Reproducible: Always

Steps to Reproduce:
1. Navigate to bug - view comment fields.
2. Change bug and commit - view mail addresses in notification mail summary. 

Actual Results:  
Font size is very small and hard to read. 

Expected Results:  
Font size be more readable as per 3.0 versions.
(Reporter)

Comment 1

11 years ago
Setting version and correcting title
Summary: Font too small in IE in Comment (show_bug.cgi) and mail addresses (process_bug.cgi) with classic skin → Font too small in IE for Comment text (show_bug.cgi) and mail addresses (process_bug.cgi) with classic skin
Version: unspecified → 3.2
(Reporter)

Comment 2

11 years ago
Posted patch v1 (obsolete) — Splinter Review
v1 Patch to template/IE-fixes.css to correct undersized text. Corrects .bz_comment_text and the email address display on process_bug.cgi. 

bz_comment_text font-size corrected separately to .uneditable_textarea.
(Assignee)

Comment 3

11 years ago
Comment on attachment 352549 [details] [diff] [review]
v1

No, this is not the right fix. The same problem appears with Firefox. I have a patch which fixes this problem.
Attachment #352549 - Flags: review-
(Assignee)

Comment 4

11 years ago
body {font-size: small;} has been added in bug 374020, without any reason AFAIK. The Dusk theme is not affected because it overrides this value.
Status: UNCONFIRMED → NEW
Depends on: 374020
Ever confirmed: true
Keywords: regression
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 3.2
(Assignee)

Comment 5

11 years ago
Posted patch patch, v1 (obsolete) — Splinter Review
Assignee: ui → LpSolit
Attachment #352549 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #352555 - Flags: review?(guy.pyrzak)
(Assignee)

Updated

11 years ago
Summary: Font too small in IE for Comment text (show_bug.cgi) and mail addresses (process_bug.cgi) with classic skin → The font size is too small with the Classic skin (especially in bug comments)

Comment 6

11 years ago
Comment on attachment 352555 [details] [diff] [review]
patch, v1

This is a huge change that is much too much. Instead I'd suggest 

pre {
  font-size:medium;
}
Attachment #352555 - Flags: review?(guy.pyrzak) → review-

Comment 7

11 years ago
Since dusk seems to be fine we can also use:
.bz_comment {
font-size:9pt;
}

which is what dusk uses for its comments.
(In reply to comment #7)
> Since dusk seems to be fine we can also use:
> .bz_comment {
> font-size:9pt;
> }

I think modifing the "font-size" parameter works fine. (like comment #6)
# I've tested at RC1 or 2 age..

But I'd like to argue using the fixed "<numeric> pt" value in our default CSS, at the viewpoint of UE.
(Assignee)

Comment 9

11 years ago
Posted patch patch, v2 (obsolete) — Splinter Review
As discussed on IRC.
Attachment #352555 - Attachment is obsolete: true
Attachment #352676 - Flags: review?(guy.pyrzak)
This fix doesn't seem quite right, in view of the fact that things work fine in Dusk but not in Classic. What are we doing in Dusk that's different?
(Assignee)

Comment 11

11 years ago
(In reply to comment #10)
> This fix doesn't seem quite right, in view of the fact that things work fine in
> Dusk but not in Classic. What are we doing in Dusk that's different?

Dusk overrides font sizes defined in global.css, and replaces them by fixed font sizes (e.g. 9pt). But this works in Dusk because it uses fixed font sizes everywhere (not only for comments). We cannot do the same in Classic without fixing all relative font sizes by fixed ones, which is IMO too much changes.
Okay, agreed. Although I thought we fixed this in some other way for .uneditable_textarea (that I'd think we should do the same with for comments).
(Assignee)

Comment 13

11 years ago
Posted patch patch, v3Splinter Review
As discussed with pyrzak on IRC, <kbd> also uses monospace, so we must include this tag too, else release notes really look weird with IE.
Attachment #352676 - Attachment is obsolete: true
Attachment #352908 - Flags: review?(guy.pyrzak)
Attachment #352676 - Flags: review?(guy.pyrzak)

Comment 15

11 years ago
Comment on attachment 352908 [details] [diff] [review]
patch, v3

looks good to me. It might also fix the other bug that is assigned to me that has the same issue.
Attachment #352908 - Flags: review?(guy.pyrzak) → review+

Comment 16

11 years ago
(Assignee)

Updated

11 years ago
Flags: approval3.2+
Flags: approval+
(Assignee)

Comment 17

11 years ago
tip:

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.57; previous revision: 1.56
done

3.2:

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.47.2.6; previous revision: 1.47.2.5
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.