469157 - browser.fixup.alternate.enabled being set to false has no effect. domain guessing still works.

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[zer0vett3]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4

I'm trying to disable domain guessing by setting browser.fixup.alternate.enabled to false however it does not work.  I've verified this on multiple PCs, and multiple Firefox versions.

Reproducible: Always

Steps to Reproduce:
1. Set browser.fixup.alternate.enabled to false
2. type anything in the address bar , hit ctrl+enter and it still will add www. as the prefix and .com as the suffix
Actual Results:  
typed google in the address bar and hit ctrl+enter and firefox added www. and .com for me.

Expected Results:  
firefox should not have added a www. prefix or .com suffix.

Comment 1

[Adam Sampson]

That's because that behaviour isn't domain guessing -- domain guessing is where it'll do that after failing to resolve a name you've entered, whereas the shift/ctrl-and-enter thing is meant to be explicitly invoked by the user. Domain guessing is done in a bit of C++ code that does look at that preference; the modifier-and-enter thing is done in Javascript (base/content/browser.js) and doesn't.

On the other hand, I also find this sufficiently annoying to want to turn it off, since I keep hitting shift-enter by mistake when typing something into the location bar that ends with '"'. I'll attach a patch that adds a second preference to disable this behaviour. (I'm open to better suggestions for a name for the preference!)

Comment 2

[Adam Sampson]

Attachment: Patch that adds a preference to disable the modifier-and-enter behaviour

Comment 3

[Tyler Downer [He/Him]]

Reporter, are you still seeing this issue with Firefox 3.6.10 or later in safe mode or a fresh profile? If not, please close. These links can help you in your testing.
http://support.mozilla.com/kb/Safe+Mode
http://support.mozilla.com/kb/Managing+profiles

Comment 4

[Tyler Downer [He/Him]]

No reply from reporter, INCOMPLETE. Please retest with Firefox 3.6.12 or later and a new profile (http://support.mozilla.com/kb/Managing+profiles). If you continue to see this issue with the newest firefox and a new profile, then please comment on this bug.

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

Confirmed against Mozilla/5.0 (Windows NT 5.1; rv:8.0a1) Gecko/20110804 Firefox/8.0a1 ID:20110804072849

I set browser.fixup.alternate.enabled;false, restarted Firefox and still CTRL+ENTER resolves to www.<String>.com in URL Bar.

Adam, if you still like to get your Patch reviewed try one of the People here:
http://www.mozilla.org/projects/firefox/review.html

Comment 6

[Sid]

(In reply to XtC4UaLL [:xtc4uall] from comment #5)
> I set browser.fixup.alternate.enabled;false, restarted Firefox and still
> CTRL+ENTER resolves to www.<String>.com in URL Bar.

Confirmed on the latest Nightly build (Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/15.0 Firefox/15.0a1). Seems like a simple and harmless enough patch, could somebody please review and land it?

Comment 7

[Dmitry Kubov]

I confirm this on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20100101 Firefox/16.0
FF16b6

I type "uo." in location bar. Since I visited that site "com/" auto added and highlighted. So I have "uo.com/" in location bar. I press enter key.

I have noscript plugin installed so I see all details. Now weird actions performed - FF adds "www." prefix, goes to www.uo.com, redirected to www.uoherald.com and redirected again to uo.com - url I wanted to visit.

I have tried to set browser.fixup.alternate.enabled;false - nothing changed. I have tried to change www. prefix in preferences - nothing changed.

Comment 8

[Dmitry Kubov]

One more url I had issues with - mgts.ru
FF always added www. and tried to load www.mgts.ru
They had some DNS config issues and I got host not found errors. Now they made DNS record for www and redirect to mgts.ru unlucky FF users like me.

Comment 9

[Wouter Koersen]

I use two different profiles here. One has a Socks Proxy and one a HTTP proxy. On the one with the socks proxy url fixup parameters seem to work as intended, but if I use the same fixup settings on the profile with the HTTP proxy it always prefixes www. and postfixes .com, no matter what I do to the fixup parameters.

I don't think it's the proxy itself that causes this problem, but it is hard to tell for me.

Comment 10

[stoja07]

I am seeing this issue in Forefox 29. When I copy one word and quickly press Ctrl + T to open a new tab and then quickly Ctrl + V to paste and Enter, the word is automatically turned into the format "www.word.com". Domain guessing has been turned off. This happens only if I quickly perform the actions above. If I wait after pasting the word to the address bar, it won't occur.

Comment 12

[Binary_101]

I can confirm this bug with FF 35.0.1 in both Normal Mode and Safe Mode. Same behavior as @Wouter Koersen described.

Comment 13

[Alexander Platzer]

Using FF 36.0.4 in win8.1 -> alternate suffix not working when using system proxy (http), works smoothly when setting is changed to "no proxy"

Comment 14

[Chris Ilias [:cilias]]

As per comment 1, browser.fixup.alternate.enabled does not apply to holding the Ctrl key.