Closed Bug 469177 Opened 13 years ago Closed 13 years ago

red/green analysis (cx->fp) doesn't actually run the analysis

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dmandelin, Unassigned)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
This was discovered by the failure of the failure test cases in bug 468937 to fail. The problem was that 'this' was used inside a closure with the intent to set properties on the enclosing object, which doesn't work. Once I fixed this I also found a bug with an uninitialized property in Treehydra, which I went ahead and fixed. I verified that the failure test cases now fail, but that's it.
Attachment #352576 - Flags: review?(jorendorff)
Given that comment about missing properties, do we also need to change "delete isn.redInfo" to "isn.redInfo = undefined" below?
Attached patch PatchSplinter Review
Attachment #352576 - Attachment is obsolete: true
Attachment #352624 - Flags: review?(jorendorff)
Attachment #352576 - Flags: review?(jorendorff)
Attachment #352624 - Flags: review?(jorendorff) → review+
Note: this patch makes the analysis run, but it issues bogus errors because it doesn't seem to recognize the green-to-red functions. I can file a separate bug about that if you like.
Pushed to tracemonkey: http://hg.mozilla.org/tracemonkey/rev/1e6682969ba9
Whiteboard: fixed-in-tracemonkey
merged in mc
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
do we want this on the branch?
Flags: wanted1.9.1?
nevermind, we would need a bunch of stuff from m-c too
Flags: wanted1.9.1?
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.