469177 - red/green analysis (cx->fp) doesn't actually run the analysis

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[David Mandelin [:dmandelin]]

Attachment: Patch

This was discovered by the failure of the failure test cases in bug 468937 to fail. The problem was that 'this' was used inside a closure with the intent to set properties on the enclosing object, which doesn't work. Once I fixed this I also found a bug with an uninitialized property in Treehydra, which I went ahead and fixed. I verified that the failure test cases now fail, but that's it.

Comment 1

[Jason Orendorff [:jorendorff]]

Given that comment about missing properties, do we also need to change "delete isn.redInfo" to "isn.redInfo = undefined" below?

Comment 2

[David Mandelin [:dmandelin]]

Attachment: Patch

Comment 3

[Benjamin Smedberg]

Note: this patch makes the analysis run, but it issues bogus errors because it doesn't seem to recognize the green-to-red functions. I can file a separate bug about that if you like.

Comment 4

[Benjamin Smedberg]

Pushed to tracemonkey: http://hg.mozilla.org/tracemonkey/rev/1e6682969ba9

Comment 5

[Robert Sayre]

merged in mc

Comment 6

[Robert Sayre]

do we want this on the branch?

Comment 7

[Robert Sayre]

nevermind, we would need a bunch of stuff from m-c too