469196 - WebService function to update a user's group membership

Status: RESOLVED FIXED

(Bugzilla :: WebService, enhancement)

Description

[Doug Warner]

Looking for a way to update an existing user's group membership.

We commonly have existing users that we would like to assign to new groups for product privileges and automating this would speed up project creation.

This is for use at Mozdev so we can help test/debug/develop the extensions as well.

Comment 1

[Max Kanat-Alexander]

I suspect this should be an extension to User.update, after User.update is done. (We don't yet have a bug for User.update, so we'd want to have one and make this bug depend on that one.)

Comment 3

[Simon Green]

Attachment: bug469196-v1.patch

Surely it can't be this easy? :)

The change in Bugzilla/User.pm, was so that add/remove is per documentation. editusers.cgi only uses the set option, so didn't need to be changed.

Comment 4

[:glob ✱]

Comment on attachment 8444179 [details] [diff] [review]
bug469196-v1.patch

Review of attachment 8444179 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

this code looks good, however the documentation needs some fixing which can happen prior to commit.

::: Bugzilla/WebService/User.pm
@@ +765,5 @@
> +=item C<set_bless_groups>
> +
> +C<hash> - This is the same as set_groups, but affects what groups a user
> +has direct membership to bless that group. It takes the same inputs as
> +set_groups.

"set_groups" doesn't make any sense in this context as it isn't a webservice method.
you probably want "groups".

Comment 5

[:glob ✱]

this needs a relnote for extensions which may be calling $user->set_group() with removed/added.

Comment 6

[:glob ✱]

(In reply to Byron Jones ‹:glob› from comment #5)
> this needs a relnote for extensions which may be calling $user->set_groups()
> with removed/added.

simon pointed out that set_groups was added in bug 442013, so it isn't part of any stable bugzilla version.
no need to relnote this change.

Comment 7

[Simon Green]

(In reply to Byron Jones ‹:glob› from comment #4)
> Comment on attachment 8444179 [details] [diff] [review]
> bug469196-v1.patch
> 
> Review of attachment 8444179 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=glob
> 
> this code looks good, however the documentation needs some fixing which can
> happen prior to commit.
> 
> ::: Bugzilla/WebService/User.pm
> @@ +765,5 @@
> > +=item C<set_bless_groups>
> > +
> > +C<hash> - This is the same as set_groups, but affects what groups a user
> > +has direct membership to bless that group. It takes the same inputs as
> > +set_groups.
> 
> "set_groups" doesn't make any sense in this context as it isn't a webservice
> method.
> you probably want "groups".

Correct. I removed the three occurrences of set_ in the above code. It was copied and pasted straight from Bugzilla/User.pm.

To ssh://[e-mail]/bugzilla/bugzilla.git
   dbd6f8f..2db0429  master -> master