Closed
Bug 469268
Opened 16 years ago
Closed 16 years ago
More tests for Wave decoder backend
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: kinetik, Assigned: kinetik)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file, 2 obsolete files)
|
95.96 KB,
patch
|
Details | Diff | Splinter Review |
I have a set of tests for bug 468992, bug 468190, bug 465498, and bug 469266, but the tests fail unless some other bug is fixed. To simplifying landing, I've split the tests out into their own bug (this one). The bugs mentioned above have patches with no tests attached that build and run all existing tests without failing. Once (or at the same time as) all of those bugs land, the tests in this bug can also land.
Flags: blocking1.9.1?
|
Assignee | |
Comment 1•16 years ago
|
||
|
|
Assignee | |
Updated•16 years ago
|
|
|
Assignee | |
Comment 2•16 years ago
|
||
Comment on attachment 352678 [details] [diff] [review]
patch v0
Not sure if tests need review, but requesting to be safe.
Attachment #352678 -
Flags: superreview?(roc)
Attachment #352678 -
Flags: review?(roc)
Attachment #352678 -
Flags: superreview?(roc)
Attachment #352678 -
Flags: superreview+
Attachment #352678 -
Flags: review?(roc)
Attachment #352678 -
Flags: review+
Not blocking per se, but definitely wanted. Anyway test changes can land without approval.
Flags: blocking1.9.1? → wanted1.9.1+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Rebased against current trunk. Added tests for timeupdate events for Wave playback. Added a test for WAVE files with leading list/info chunks.
Attachment #352678 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•16 years ago
|
||
And also enable test_wav_trunc.html again (disabled in bug 474754), since the patch in bug 469266 should make the test reliable.
|
|
Assignee | |
Comment 6•16 years ago
|
||
Same as v2, but rebased on top of latest changes to test dir.
Attachment #362181 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•16 years ago
|
||
Note that bug 469266 must land before this.
Keywords: checkin-needed
Whiteboard: [needs landing]
|
||
Updated•16 years ago
|
Whiteboard: [needs landing] → [needs landing: 469266 first !]
|
|
||
Comment 8•16 years ago
|
||
Comment on attachment 362514 [details] [diff] [review]
patch v2.1
[Checkin: Comment 8]
http://hg.mozilla.org/mozilla-central/rev/9db614caf1da
Attachment #362514 -
Attachment description: patch v2.1 → patch v2.1
[Checkin: Comment 8]
|
|
||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing: 469266 first !] → [needs 1.9.1 landing: Bug 469266 first !]
Target Milestone: mozilla1.9.1 → mozilla1.9.2a1
Whiteboard: [needs 1.9.1 landing: Bug 469266 first !] → [needs 1.9.1 landing]
Keywords: fixed1.9.1
Whiteboard: [needs 1.9.1 landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•