Closed Bug 469276 Opened 16 years ago Closed 15 years ago

Alignment problem in toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp

Categories

(Toolkit :: Safe Browsing, defect)

Product:
Toolkit
Component:
Safe Browsing
Platform:
Sun
NetBSD
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 448658

People

(Reporter: martin, Assigned: martin)

Details

Attachments

(1 file, 1 obsolete file)

revised patch, fixing both instances
1.18 KB, patch
dcamp
: review+
Details | Diff | Splinter Review
Attached patch proposed fix (obsolete) — — Splinter Review 
A nsCSubString may be aligned (depending on compiler, optimization settings, etc) unsuitably to cast it's contents address to a 32bit pointer. The attached patch fixes the problem for me on a NetBSD/sparc64 machine.
Component: Places → Phishing Protection
Product: Toolkit → Firefox
QA Contact: places → phishing.protection
Version: unspecified → Trunk
Attachment #352684 - Flags: review?(dcamp)
Assignee: nobody → martin
Summary: Alignement problem in toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp → Alignment problem in toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp
Sorry, there is a second instance of the same code (just search for PR_nthol) further down in the same file that needs the same treatment - I'll update the patch.
Attachment #352684 - Attachment is obsolete: true
Attachment #352684 - Flags: review?(dcamp)
Attachment #352737 - Flags: review?(dcamp)
Comment on attachment 352737 [details] [diff] [review]
revised patch, fixing both instances

Looks good, but please convert the tabs to spaces.
Attachment #352737 - Flags: review?(dcamp) → review+
I guess the bug 448658 is about the same issue, right?
Yes, looks the same to me.
And this patch doesn't fixes it either :/
Since the bug i filed is older, and this has been fixed in trunk, i'll dupe it, yet this doesn't fix it for me, as it sigbuses around 45 minutes later.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: