Closed
Bug 469554
Opened 16 years ago
Closed 16 years ago
Use pluralForm in Task tree - Due In column
Categories
(Calendar :: Tasks, defect)
Calendar
Tasks
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: wladow, Assigned: wladow)
Details
Attachments
(1 file)
|
2.93 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
We are using different strings for 1,2 and N hours/days in Task tree - Due In column, what is insufficient workaround. Let's use pluralForm instead.
Attachment #352916 -
Flags: review?(philipp)
|
||
Updated•16 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•16 years ago
|
Attachment #352916 -
Flags: review?(philipp) → review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 352916 [details] [diff] [review] use pluralForm v1 >diff --git a/calendar/base/content/calendar-task-tree.xml b/calendar/base/content/calendar-task-tree.xml >--- a/calendar/base/content/calendar-task-tree.xml >+++ b/calendar/base/content/calendar-task-tree.xml >@@ -200,25 +200,17 @@ > <method name="duration"> > <parameter name="aTask"/> > <body><![CDATA[ >+ Components.utils.import("resource://gre/modules/PluralForm.jsm"); I'd prefer this happening in the <resource> block, but I believe thats not possible. Instead, lets do so once in the constructor. r=philipp with that fixed, will do so before checkin.
|
|
||
Comment 2•16 years ago
|
||
While at it, I also moved the ctor/dtor to the top of the implementation. Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/162f1c271f14> -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
|
|
||
Updated•14 years ago
|
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•