469583 - Coverity: uninitialized variable used in sec_pkcs5CreateAlgorithmID

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Nelson Bolyard (seldom reads bugmail)]

According to Coverity run 278, CID 1397, 
in file nss/lib/pk11wrap/pk11pbe.c, sec_pkcs5CreateAlgorithmID, 
if the attempt to allocate a new arena fails, leaving poolp == NULL,

 	    poolp = PORT_NewArena(SEC_ASN1_DEFAULT_ARENA_SIZE);

the code will reach these lines of code at the bottom of the function:

    if (pbe_param) {
        sec_pkcs5_destroy_pbe_param(pbe_param);
    }

with pbe_param uninitialized.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Another issue reported in the same function, same coverity run and SID

622  		if (sec_pkcs5_is_algorithm_v2_pkcs5_algorithm(algorithm)) {

If sec_pkcs5_is_algorithm_v2_pkcs5_algorithm returns true, then in the 
following statement,

623  		    if (cipherAlgorithm == SEC_OID_UNKNOWN) {

cipherAlgorithm is uninitialized.  However, it appears to me that this 
issue has already been fixed on the trunk.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Both of these issues have already been fixed on the trunk.