Closed
Bug 469615
Opened 17 years ago
Closed 16 years ago
Fix HASH_GetHMACOidTagByHashOidTag
Categories
(NSS :: Libraries, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.12.7
People
(Reporter: nelson, Assigned: shailen.n.jain)
Details
(Keywords: coverity)
Attachments
(1 file, 1 obsolete file)
|
1.03 KB,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
Coverity caught this one. CID 1258 file nss/lib/cryptohi/sechash.c
Function HASH_GetHMACOidTagByHashOidTag ignores its input argument and
produces a constant output. It always sets error
SEC_ERROR_INVALID_ALGORITHM and returns SEC_OID_UNKNOWN.
Clearly it has never been tested.
Is it used? Is it really needed?
If not, let's get rid of it.
Summary: HASH_GetHMACOidTagByHashOidTag obviously untested - do we need it? → Remove HASH_GetHMACOidTagByHashOidTag
|
Reporter | |
Comment 2•16 years ago
|
||
Comment on attachment 430930 [details] [diff] [review]
remove it
r=nelson
Attachment #430930 -
Flags: review+
|
||
Comment 3•16 years ago
|
||
Comment on attachment 430930 [details] [diff] [review]
remove it
r-
I actually needed this function recently. It's supposed to be exported.
bob
Attachment #430930 -
Flags: review?(rrelyea) → review-
|
|
||
Comment 4•16 years ago
|
||
the first 2 instances of hmacoid should be hashoid.
|
|
Reporter | |
Updated•16 years ago
|
Attachment #430930 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•16 years ago
|
Assignee: timeless → rrelyea
Status: ASSIGNED → NEW
Summary: Remove HASH_GetHMACOidTagByHashOidTag → Fix HASH_GetHMACOidTagByHashOidTag
|
|
Reporter | |
Updated•16 years ago
|
Priority: -- → P2
Hi Bob,
Can you please review this patch?
Thanks,
Shailendra
Attachment #436458 -
Flags: review?(rrelyea)
|
|
Reporter | |
Updated•16 years ago
|
Attachment #436458 -
Flags: review?(rrelyea) → review+
|
|
Reporter | |
Comment 6•16 years ago
|
||
Comment on attachment 436458 [details] [diff] [review]
Patch V 1
r=nelson
|
|
Reporter | |
Comment 7•16 years ago
|
||
Bug 469615: Fix HASH_GetHMACOidTagByHashOidTag
Patch contributed by Shailendra Jain <shailen.n.jain@gmail.com>, r=rrelyea
Checking in cryptohi/sechash.c; new revision: 1.10; previous revision: 1.9
Assignee: rrelyea → shailen.n.jain
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.12.7
You need to log in
before you can comment on or make changes to this bug.
Description
•