469622 - Coverity errors reported in ckfw

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Nelson Bolyard (seldom reads bugmail)]

File nss/lib/ckfw/token.c function nssCKFWToken_Destroy

CID 1384 - pointer dereference before NULL check

393  nssCKFWHash_Iterate(fwToken->mdObjectHash, nss_ckfwtoken_object_iterator, 
394                      (void *)NULL);
395  if (fwToken->mdObjectHash) {
396      nssCKFWHash_Destroy(fwToken->mdObjectHash);
397  }

Here, fwToken->mdObjectHash is passed to nssCKFWHash_Iterate, which 
dereferences it.  THEN it is checked for NULL.

Comment 1

[Shailen]

Attachment: Patch V 1

Hi Nelson,

  I moved the if condition one line above to ensure fwToken->mdObjectHash is not NULL before fwToken->mdObjectHash being dereferenced through nssCKFWHash_Iterate.

  Please review and let me know I had missed anything.

Regards,
Shailendra

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 430912 [details] [diff] [review]
Patch V 1

I believe this patch is correct.  
Bob, do you agree? 
If so, please SR and commit.

Comment 3

[Robert Relyea]

Comment on attachment 430912 [details] [diff] [review]
Patch V 1

r+ seems right to me as well.

Comment 4

[timeless]

please lose the trailing space when you commit this (i just wrote this patch myself)

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Committed token.c rev 1.16
Thanks Shailendra