469639 - failed to build firefox trunk on OpenSolaris

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Boying Lu]

Attachment: Use "-eq" instead of "=="

When configure firefox trunk on OpenSolaris, I got following error:
checking MOZ_DBUS_GLIB_CFLAGS... -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
checking MOZ_DBUS_GLIB_LIBS... -ldbus-glib-1 -ldbus-1 -lgobject-2.0 -lglib-2.0  
/export/home/brian/moz-ws/community3/1215/mozilla-central/configure: test: unknown operator ==
*** Fix above errors and then restart with "make -f client.mk build"

The root cause is that /bin/sh is not bash on Solaris

Comment 1

[Boying Lu]

Attachment: define HAVE_ALLOCA_H on Solaris

Comment 2

[cajbir (:cajbir)]

Comment on attachment 353001 [details] [diff] [review]
define HAVE_ALLOCA_H on Solaris

Please add to README_MOZILLA the number of the bug this patch is for. Thanks!

Comment 3

[Boying Lu]

Attachment: adding bug number in README_MOZILLA [Checkin: Comment 6]

Comment 4

[Wan-Teh Chang]

Comment on attachment 353000 [details] [diff] [review]
Use "-eq" instead of "=="

r=wtc.  But I'd like to suggest that you use = (just one equal sign)
instead of -eq.  I'm not a shell programming expert, so I just looked
at the existing usage of "test" in mozilla/configure.in and
mozilla/nsprpub/configure.in.  I found that for string comparision,
= is always used.  So it'd be nice to be consistent with current usage.

Comment 5

[Boying Lu]

Attachment: replace '-eq' with '=' [See bug 468463]

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 353003 [details] [diff] [review]
adding bug number in README_MOZILLA
[Checkin: Comment 6]

http://hg.mozilla.org/mozilla-central/rev/6af107f076c7