provide 64 bit MAC OS X support to nss

RESOLVED FIXED in 3.12.3

Status

defect
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: glenbeasley, Assigned: glenbeasley)

Tracking

trunk
3.12.3
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

11 years ago
No description provided.
This bug is incomplete.  It has no description.  
Please fix it ASAP.
Assignee

Comment 2

11 years ago
provide 64 bit MAC OS X support for nss
Assignee

Updated

11 years ago
Summary: 64 bit MAC OS X support → provide 64 bit MAC OS X support to nss
Assignee

Comment 3

10 years ago
I understand if this patch is denied due to the explicit check in
nss_FindExternalRoot for the root certs library.
Attachment #364696 - Flags: review?
Assignee

Comment 4

10 years ago
Solution B depends on a fix to bug 480730 PR_LoadLibrary for 64 bit MAC OS X interprets "./libname" relatively
Depends on: 480730
Assignee

Updated

10 years ago
Attachment #364696 - Attachment description: provide 64 bit support solution A → provide 64 bit support patch A
Attachment #364696 - Flags: review? → review?(wtc)
Assignee

Updated

10 years ago
Attachment #366366 - Flags: review?(wtc)
This is not a review of either patch, but I wish to express a strong 
preference for the approach of the second patch, the one that puts the
fix for the loading problem in NSPR.  I believe that's where it belongs.

Updated

10 years ago
Attachment #364696 - Attachment is obsolete: true
Attachment #364696 - Flags: review?(wtc)

Comment 7

10 years ago
Comment on attachment 366366 [details] [diff] [review]
provide 64 bit support patch B requires nspr bug 480730

r=wtc.  Some suggested changes before you check this in.

1. Use

    ifdef USE_64

instead of

    ifeq ($(USE_64),1)

Simarly, "ifndef USE_64" instead of "ifneq ($(USE_64),1)".

2. In Darwin.mk, you may want to consider just adding -arch x86_64
to the compiler 'CC'.  Then you won't need to add -arch x86_64 to
both OS_REL_CFLAGS and DSO_LDOPTS.  That's how it's done in NSPR:
http://mxr.mozilla.org/mozilla-central/source/nsprpub/configure.in#1002
Attachment #366366 - Flags: review?(wtc) → review+
Assignee

Comment 8

10 years ago
thanks for review wan-teh.

Checking in coreconf/Darwin.mk;
/cvsroot/mozilla/security/coreconf/Darwin.mk,v  <--  Darwin.mk
new revision: 1.21; previous revision: 1.20
done
Checking in nss/lib/ckfw/builtins/config.mk;
/cvsroot/mozilla/security/nss/lib/ckfw/builtins/config.mk,v  <--  config.mk
new revision: 1.13; previous revision: 1.12
done
Checking in nss/lib/ckfw/capi/config.mk;
/cvsroot/mozilla/security/nss/lib/ckfw/capi/config.mk,v  <--  config.mk
new revision: 1.2; previous revision: 1.1
done
Attachment #366366 - Attachment is obsolete: true
Assignee

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.12.3
You need to log in before you can comment on or make changes to this bug.