469738 - provide 64 bit MAC OS X support to nss

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

This bug is incomplete.  It has no description.  
Please fix it ASAP.

Comment 2

[glen beasley]

provide 64 bit MAC OS X support for nss

Comment 3

[glen beasley]

Attachment: provide 64 bit support patch A

I understand if this patch is denied due to the explicit check in
nss_FindExternalRoot for the root certs library.

Comment 4

[glen beasley]

Solution B depends on a fix to bug 480730 PR_LoadLibrary for 64 bit MAC OS X interprets "./libname" relatively

Comment 5

[glen beasley]

Attachment: provide 64 bit support patch B requires nspr bug 480730

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

This is not a review of either patch, but I wish to express a strong 
preference for the approach of the second patch, the one that puts the
fix for the loading problem in NSPR.  I believe that's where it belongs.

Comment 7

[Wan-Teh Chang]

Comment on attachment 366366 [details] [diff] [review]
provide 64 bit support patch B requires nspr bug 480730

r=wtc.  Some suggested changes before you check this in.

1. Use

    ifdef USE_64

instead of

    ifeq ($(USE_64),1)

Simarly, "ifndef USE_64" instead of "ifneq ($(USE_64),1)".

2. In Darwin.mk, you may want to consider just adding -arch x86_64
to the compiler 'CC'.  Then you won't need to add -arch x86_64 to
both OS_REL_CFLAGS and DSO_LDOPTS.  That's how it's done in NSPR:
http://mxr.mozilla.org/mozilla-central/source/nsprpub/configure.in#1002

Comment 8

[glen beasley]

Attachment: patch as checked in

thanks for review wan-teh.

Checking in coreconf/Darwin.mk;
/cvsroot/mozilla/security/coreconf/Darwin.mk,v  <--  Darwin.mk
new revision: 1.21; previous revision: 1.20
done
Checking in nss/lib/ckfw/builtins/config.mk;
/cvsroot/mozilla/security/nss/lib/ckfw/builtins/config.mk,v  <--  config.mk
new revision: 1.13; previous revision: 1.12
done
Checking in nss/lib/ckfw/capi/config.mk;
/cvsroot/mozilla/security/nss/lib/ckfw/capi/config.mk,v  <--  config.mk
new revision: 1.2; previous revision: 1.1
done