469805 - Cookies are not sent by saving attachment by right click when third-party cookies are disabled

Status: RESOLVED FIXED

(Firefox :: File Handling, defect)

Description

[Marek Sykora]

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.0; Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1) ; SLCC1; .NET CLR 2.0.50727; .NET CLR 3.0.04506)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; cs; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4

Happens only when using right click, left click works properly.

Reproducible: Always

Steps to Reproduce:
1. disable the "Accept third-party cookies" setting in "Tools -> Options -> Privacy -> Cookies"
2. log into GMail
3. sent yourself a mail with attachment
4 [review]. read the mail and download the attachment using right click on link "Download"
Actual Results:  
Filename "ServiceLogin" is offered, the attachment is incorrectly downloaded, it's content contains GMail's relogin page because cookies have not been sent and GMail thinks session expires.

Expected Results:  
The attachment should be correctly downloaded as same as "Accept third-party cookies" is enabled.

Caused by missing "Cookies" header according to captured network traffic.

Comment 1

[Dave Garrett]

Sounds like this might be bug 437174. Not sure.

(oh, and BugZilla went a little linkify-happy on you ;)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Once bug 437174 is fixed, this is going to need to be fixed in the Firefox UI (using the APIs that bug will add).

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Dan, do you know what needs to be changed in the front end in order to properly support this now that bug 437174 is fixed?

Comment 4

[[e-mail]]

It looks like the necessary changes were already made to contentAreaUtils.js and nsWebBrowserPersist.cpp, before 3.6 branched: https://bugzilla.mozilla.org/show_bug.cgi?id=437174#c95

Tested 3.5 and it's broken, tested trunk and it works. So we should be good here.

Comment 5

[Lazaro]

I up to date to Firefox/3.5.2 in my system windows XP, after this my site don't read right the cookies. The last version was very well. I don't understand very well if the problem up writted is the same, but I writte about this now.
Thanks.
L.J.A.