I need to add a testcase for the two types of Search textboxes and their correct a11y exposures, as enhanced by bug 469367 anyway, and may as well refactor the files in the process.
Created attachment 353223 [details] [diff] [review] Patch
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED
Attachment #353223 - Flags: review?(surkov.alexander)
Attachment #353223 - Flags: review?(surkov.alexander) → review+
Comment on attachment 353223 [details] [diff] [review] Patch >-function testStates(aAccOrElmOrID, aState, aExtraState, aAbsentState) >+function testStates(aAccOrElmOrID, aState, aExtraState, aAbsentState, >+ aAbsentExtraState) nit: I would prefer to add new line before aAbsentState (not before aAbsentExtraState) - this will group similar arguments visually. >+ >+ ////////////////////////////////////////////////////////////////////////// >+ // Search textbox with search button, does not support autoCompletion. >+ testThis("searchfield", // ID >+ "Search all add-ons", // name ... >+ "Activate"); // ActionDescription >+ testStates("searchfield", 0, 0, 0, EXT_STATE_SUPPORTS_AUTOCOMPLETION); it's not elegant solution though, I'm ready to take this as temporary one. > </hbox> > <vbox> > <label control="readonly_textarea">This textarea is readonly, too:</label> > <textbox multiline="true" id="readonly_textarea" readonly="true" cols="80" > rows="5" value="You cannot change me, either."/> > </vbox> >+ <hbox> >+ <label value="Search History:" accesskey="S" >+ control="search-box"/> >+ <textbox id="search-box" flex="1" type="search" cocoa-size="small" >+ aria-controls="historyTree"/> nit: lineup textbox tag properly please (tabs there?). r=me
Decided to take the part about adding a testcase for bug 469367 out of this refactor. Bug 469367 may take a bit longer still, and I'll include the mochitest for that bug there.
Summary: Refactor test_textboxes.* files, and add testcase for bug 469367. → Refactor test_textboxes.* files
Created attachment 355568 [details] [diff] [review] Patch to go into Mercurial. This is the patch that actually will be pushed.
Pushed in changeset: http://hg.mozilla.org/mozilla-central/rev/43c4563d77e4 And the test_textboxes.xul file was reenabled in changeset: http://hg.mozilla.org/mozilla-central/rev/175db8c77a18
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.