469862 - Save crash reports in pending if the server responds "discarded due to throttling"

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Benjamin Smedberg]

We want to discard 90% of crash report submissions on the server (at least for Windows users). The server can notify the client that the submission was throttled by returning a null crash ID. The client should then save the crash report in the pending/ directory so that the user can manually resubmit it from about:crashes (bug 378528).

We should save the last 10 throttled crashes, I think, and scrub the rest.

Comment 1

[Benjamin Smedberg]

Attachment: Detect server throttling, rev. 1

NOTE: this patch will save the throttled reports, but won't ever clear old reports out of the pending directory. I'll do that in a different patch.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 353708 [details] [diff] [review]
Detect server throttling, rev. 1

Nice and simple. :)

Comment 3

[(not currently active) Ted Mielczarek]

Oh, I also think we should file a followup bug about possibly changing the text the user sees when this happens. Might be confusing if they see "submitted successfully" and then visit about:crashes to find out that it wasn't actually submitted.

Comment 4

[(not currently active) Ted Mielczarek]

This landed yesterday:
http://hg.mozilla.org/mozilla-central/rev/31dbaf4ca0c4

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

a191=beltzner; please make sure to also get bug 378528 landed in order to round out the user experience here as per comment 1.

(In reply to comment #3)
> Oh, I also think we should file a followup bug about possibly changing the text
> the user sees when this happens. Might be confusing if they see "submitted
> successfully" and then visit about:crashes to find out that it wasn't actually
> submitted.

That'll have to miss 191 as we've missed string freeze, but sure. "Thanks for helping Mozilla" or something as a confirmation of completion would work well.

Comment 6

[Benjamin Smedberg]

Attachment: Send a throttling flag with the request, per bug 469863

Per bug 469863, send a Throttleable=1 flag with the request

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 355634 [details] [diff] [review]
Send a throttling flag with the request, per bug 469863

bug 469863 comment 8 suggests that Lars would prefer "Resubmission=0". Either way it doesn't matter much, since the resubmit code is going to wind up being JavaScript anyway.

Comment 8

[Benjamin Smedberg]

Followup in mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/1d1533aff4ab

Both patches in 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/82bfab302f3c
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/89d3d765935c