Closed
Bug 469905
Opened 16 years ago
Closed 16 years ago
nsGlobalWindow::SetNewDocument gets the wrong context for termination functions
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
DUPLICATE
of bug 466826
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(1 file)
|
1.92 KB,
patch
|
mrbkap
:
review+
mrbkap
:
superreview+
|
Details | Diff | Splinter Review |
Found by bz in bug 466826, this is a regression from bug 460811.
Attachment #353315 -
Flags: superreview?(jst)
Attachment #353315 -
Flags: review?(mrbkap)
|
||
Updated•16 years ago
|
Attachment #353315 -
Flags: superreview?(jst)
Attachment #353315 -
Flags: superreview+
Attachment #353315 -
Flags: review?(mrbkap)
Attachment #353315 -
Flags: review+
|
||
Comment 1•16 years ago
|
||
I still think the right thing to do is to pop off |cx| and push it back on around this code. That would fix both this bug and bug 466826, no? As it is, that bug is still unfixed...
|
Assignee | |
Comment 2•16 years ago
|
||
I thought you said in bug 466826 comment 3 that fixing the context issue wouldn't prevent the assertion because cx->fp would still be null?
|
|
||
Comment 3•16 years ago
|
||
Fixing it by grabbing the right context up front, as you do here (and as I suggest in that comment), wouldn't prevent the assert. Fixing it by popping the wrong context and repushing it after we set the termination function would, I think.
|
|
Assignee | |
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
|
|
Assignee | |
Comment 5•16 years ago
|
||
Ok, that does fix both. Merging this bug back over.
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•