Closed Bug 470011 Opened 16 years ago Closed 15 years ago

playback of offline imap operations needs to check if dest folder exists

Categories

(MailNews Core :: Backend, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

References

Details

Attachments

(1 file)

Attached patch proposed fixSplinter Review
We can get into situations where we have an offline imap move/copy operation to a folder that doesn't exist. Since we do all move/copy operations pseudo offline, this can affect non-offline users as well. E.g., rogue code :-) like the patch in bug 451995 can do this. Whatever the cause, the problem is that we will keep retrying the move/copy every time the source folder is selected, and it will never succeed. It also prevents us from getting new mail for that folder.

The patch makes us drop the move/copy offline operations if the dest folder doesn't exist. This will make us stop retrying.  Once the offline ops are dropped, we will redownload the headers for the affected messages.

This situation should really not happen in normal circumstances, so I've made it an assertion.
Attachment #353446 - Flags: superreview?(bugzilla)
Attachment #353446 - Flags: review?(bugzilla)
Comment on attachment 353446 [details] [diff] [review]
proposed fix

>+  nsCOMPtr <nsIMsgImapMailFolder> imapFolder = do_QueryInterface(m_currentFolder);
>+  if (imapFolder && DestFolderOnSameServer(destFolder))

nit: not your fault, but please drop the space from between the nsCOMPtr and the <
Attachment #353446 - Flags: superreview?(bugzilla)
Attachment #353446 - Flags: superreview+
Attachment #353446 - Flags: review?(bugzilla)
Attachment #353446 - Flags: review+
Blocks: 170267
fix checked in.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.