470070 - Multiple object leaks reported by tinderbox

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Alexei Volkov]

Object leaks:


vfychain -d AllDB -pp -vv   -o OID.1.0  UserCA2.der  -t Root
chains.sh: -------- Running /export/tinderlight/data/communist_32_DBG/mozilla/dist/SunOS5.11_DBG.OBJ/bin/vfychain under DBX:
/usr/dist/pkgs/sunstudio_sparc,v12.0/SUNWspro/prod/bin/dbx /export/tinderlight/data/communist_32_DBG/mozilla/dist/SunOS5.11_DBG.OBJ/bin/vfychain
chains.sh: -------- DBX commands:
dbxenv follow_fork_mode parent
dbxenv rtc_mel_at_exit verbose
dbxenv rtc_biu_at_exit verbose
check -memuse -match 16 -frames 16
run -d AllDB -pp -vv -o OID.1.0 UserCA2.der -t Root
1[43f88]: Class List leaked 1 objects of size 20 bytes, total = 20 bytes
1[43f88]: The generated error caused an object leaks. Loop 815.Stack /CERT_PKIXVerifyCert/PKIX_BuildChain/pkix_Build_InitiateBuildChain/pkix_BuildForwardDepthFirstSearch/pkix_Buil
d_ValidateEntireChain/pkix_CheckChain/pkix_CheckCert/pkix_PolicyChecker_Check/PKIX_PL_Cert_GetPolicyMappings/pkix_pl_Cert_DecodePolicyMapping/pkix_pl_oidBytes2Ascii
1[43f88]: Class List leaked 1 objects of size 20 bytes, total = 20 bytes

vfychain -d UserDB -pp -vv -f   UserCA2.der CA2CA1.der  -t Root.der
chains.sh: -------- Running /export/tinderlight/data/communist_32_DBG/mozilla/dist/SunOS5.11_DBG.OBJ/bin/vfychain under DBX:
/usr/dist/pkgs/sunstudio_sparc,v12.0/SUNWspro/prod/bin/dbx /export/tinderlight/data/communist_32_DBG/mozilla/dist/SunOS5.11_DBG.OBJ/bin/vfychain
chains.sh: -------- DBX commands:
dbxenv follow_fork_mode parent
dbxenv rtc_mel_at_exit verbose
dbxenv rtc_biu_at_exit verbose
check -memuse -match 16 -frames 16
run -d UserDB -pp -vv -f UserCA2.der CA2CA1.der -t Root.der
1[43f88]: Class Cert leaked 1 objects of size 136 bytes, total = 136 bytes
1[43f88]: Class List leaked 2 objects of size 20 bytes, total = 40 bytes
1[43f88]: The generated error caused an object leaks. Loop 687.Stack /CERT_PKIXVerifyCert/PKIX_BuildChain/pkix_Build_InitiateBuildChain/pkix_BuildForwardDepthFirstSearch/PKIX_PL_A
IAMgr_GetAIACerts/PKIX_List_Create


Assertion due to unset error code:
vfychain -d AllDB -pp -vv   -o OID.1.0  UserCA2.der CA2CA1.der  -t CA2CA1.der
chains.sh: -------- Running /export/tinderlight/data/communist_32_DBG/mozilla/dist/SunOS5.11_DBG.OBJ/bin/vfychain under DBX:
/usr/dist/pkgs/sunstudio_sparc,v12.0/SUNWspro/prod/bin/dbx /export/tinderlight/data/communist_32_DBG/mozilla/dist/SunOS5.11_DBG.OBJ/bin/vfychain
chains.sh: -------- DBX commands:
dbxenv follow_fork_mode parent
dbxenv rtc_mel_at_exit verbose
dbxenv rtc_biu_at_exit verbose
check -memuse -match 16 -frames 16
run -d AllDB -pp -vv -o OID.1.0 UserCA2.der CA2CA1.der -t CA2CA1.der
1[43f88]: Assertion failure: nssErr, at certvfypkix.c:896
Assertion failure: nssErr, at certvfypkix.c:896
Returned value is 1, expected result is pass
chains.sh: #702: Extension: Verifying certificate(s)  UserCA2.der CA2CA1.der with flags -d AllDB   -o OID.1.0  -t CA2CA1.der - FAILED

Comment 1

[Alexei Volkov]

Attachment: Patch v1 - fix for object leaks

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 353527 [details] [diff] [review]
Patch v1 - fix for object leaks

This all looks fine to me, except for the change to 
pkix_BuildForwardDepthFirstSearch in    
nss/lib/libpkix/pkix/top/pkix_build.c  

That change expects state->parentState to be valid immediately 
after the state structure has been destroyed.
I didn't understand about "build constants".  
finally, "destucted" should be "destroyed"

Comment 3

[Alexei Volkov]

Attachment: Patch v2 - do not dereference decrefed object.

Parent state should be referenced through prntState variable(pkix_build.c:3230) and not through already decref'ed state.
This patch fixes this problem.

I'll attach another patch to clean up the mess related to creating/destruction buildconstants member of state structure.

Comment 4

[Alexei Volkov]

Attachment: Patch v3

"destucted" should be "destroyed"  -- the change didn't make into the attached patch.

Comment 5

[Alexei Volkov]

Attachment: Patch v4

Remove changes for pkix_build.h file

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 353855 [details] [diff] [review]
Patch v4

ok. r=nelson

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Unsetting target milestone in unresolved bugs whose targets have passed.

Comment 8

[Alexei Volkov]

Patch was committed in December 2008