Closed
Bug 470129
Opened 13 years ago
Closed 13 years ago
Parens around case value turn tableswitch into condswitch
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: mrbkap)
Details
(Keywords: fixed1.9.1, perf, testcase, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
867 bytes,
patch
|
igor
:
review+
|
Details | Diff | Splinter Review |
dis(function (f) { switch(f) { case (0): }});
... condswitch ...
dis(function (f) { switch(f) { case 0 : }});
... tableswitch ...
This is a compilation bug and I imagine it affects both the interpreter and the JIT. I noticed this bug because condswitch slows down the JIT a lot, but that's probably a separate bug.
|
Reporter | |
Comment 1•13 years ago
|
||
Filed bug 470133 on the JIT slowness. It's only crazy-slow when there's a type mismatch.
|
Assignee | |
Comment 2•13 years ago
|
||
Seems obvious.
|
||
Comment 3•13 years ago
|
||
There's a bug on abstracting away TOK_RP nodes. At some point it's worth fixing instead of adding these loops. /be
|
|
Reporter | |
Comment 4•13 years ago
|
||
Bug 461269 - Remove TOK_RP nodes from the parse tree
|
||
Updated•13 years ago
|
Attachment #354368 -
Flags: review?(igor) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/73cb8af8db91
Whiteboard: fixed-in-tracemonkey
|
||
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/73cb8af8db91
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: wanted1.9.1+
Resolution: --- → FIXED
|
|
||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8280c2b9bbf9
Keywords: fixed1.9.1
|
||
Updated•13 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•