Closed
Bug 470170
Opened 16 years ago
Closed 16 years ago
Two gloda namespace/naming issues
Categories
(MailNews Core :: Database, defect)
MailNews Core
Database
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b2
People
(Reporter: rain1, Assigned: rain1)
Details
Attachments
(1 file)
|
2.31 KB,
patch
|
asuth
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
asuth, I'm really not familiar with the testing framework for gloda, would you be able to write unit tests for something like this?
Attachment #353629 -
Flags: superreview?(bienvenu)
Attachment #353629 -
Flags: review?(bugmail)
|
||
Updated•16 years ago
|
Attachment #353629 -
Flags: review?(bugmail) → review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 353629 [details] [diff] [review]
go javascript!
[Checkin: Comment 2]
Yes, this could/should be unit tested. We have an outstanding bug about the failure of deletion to work, which is where/when I'll add the unit tests. There are actually a few places that can capture the net result of deletion, which I presume is why things work at all in the face of these glitches...
Thank you very much for the patch.
|
||
Updated•16 years ago
|
Attachment #353629 -
Flags: superreview?(bienvenu) → superreview+
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 2•16 years ago
|
||
Comment on attachment 353629 [details] [diff] [review]
go javascript!
[Checkin: Comment 2]
http://hg.mozilla.org/comm-central/rev/ecfbea3ab9e1
Attachment #353629 -
Attachment description: go javascript! → go javascript!
[Checkin: Comment 2]
|
|
||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
|
|
||
Updated•16 years ago
|
Target Milestone: mozilla1.9.1b3 → Thunderbird 3.0b2
|
||
Comment 3•16 years ago
|
||
This FIXED bug is flagged with in‑testsuite? It would be great if assignee or someone else can clear the flag if a test is not appropriate. And if appropriate, create a test and plus the flag to finish off the bug.
|
||
Comment 4•16 years ago
|
||
Andrew, is this now covered by unit tests?
|
|
||
Comment 5•16 years ago
|
||
No, I haven't actually fixed bug 465618 yet. But soon!
You need to log in
before you can comment on or make changes to this bug.
Description
•