Closed Bug 470170 Opened 16 years ago Closed 16 years ago

Two gloda namespace/naming issues

Categories

(MailNews Core :: Database, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: rain1, Assigned: rain1)

Details

Attachments

(1 file)

asuth, I'm really not familiar with the testing framework for gloda, would you be able to write unit tests for something like this?
Attachment #353629 - Flags: superreview?(bienvenu)
Attachment #353629 - Flags: review?(bugmail)
Attachment #353629 - Flags: review?(bugmail) → review+
Comment on attachment 353629 [details] [diff] [review]
go javascript!
[Checkin: Comment 2]

Yes, this could/should be unit tested.  We have an outstanding bug about the failure of deletion to work, which is where/when I'll add the unit tests.  There are actually a few places that can capture the net result of deletion, which I presume is why things work at all in the face of these glitches...

Thank you very much for the patch.
Attachment #353629 - Flags: superreview?(bienvenu) → superreview+
Keywords: checkin-needed
Comment on attachment 353629 [details] [diff] [review]
go javascript!
[Checkin: Comment 2]

http://hg.mozilla.org/comm-central/rev/ecfbea3ab9e1
Attachment #353629 - Attachment description: go javascript! → go javascript! [Checkin: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
Target Milestone: mozilla1.9.1b3 → Thunderbird 3.0b2
This FIXED bug is flagged with in‑testsuite?   It would be great if assignee or someone else can clear the flag if a test is not appropriate.  And if appropriate, create a test and plus the flag to finish off the bug.
Andrew, is this now covered by unit tests?
No, I haven't actually fixed bug 465618 yet.  But soon!
You need to log in before you can comment on or make changes to this bug.