470207 - proxy bypass hosts/domains not parsed correctly on Mac when using system proxy settings

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Constantine V. Sokolov]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2

FF - Preferencer - Advanced - Network - Connection «Settings» - «Use system proxy settings» selected;
MacOSX - Network Preferences - AirPort «Advanced» - Proxies - FTP/HTTP/HTTPS and «Bypass proxy settings for these Hosts&Domains» typed «*.dev, *.devel»

BUT FF try connect to http://test.dev and http://mywork.devel via PROXY !!!

Safari4 is work correct with this settings.

Reproducible: Always

Steps to Reproduce:
if MacOSX System Proxy is ON and FF use System Proxy this bug is constant =(

Comment 1

[Jo Hermans]

Do NOT use a star, it very clearly explained in the example just below the field.

Comment 2

[Frank Wein [:mcsmurf]]

Invalid then?

Comment 3

[jokeyrhyme]

I can confirm this bug. I reported it in 3.1 beta 3, and it is most definitely still in 3.5 beta 4. I am using Mac OS X 10.5.6.

In System Preferences, on the Network pane, there is a text field called "Bypass roxy settings for these Hosts & Domains". By default, this field contains "*.local, 169.254/16". The star that apparently hurts Firefox is in there by default on my Mac, so maybe Firefox should be fixed to ignore stars.

Anyhow, following the above advice about the stars, I changed that line to ".local, 169.254/16, 192.168/16" so I can connect directly to hosts on my network. I can confirm that Safari 4 beta is able to connect directly to 192.168.0.1 and to www.google.com (via proxy) as expected.

However, Firefox 3.5 beta 4 (with these settings), still engages the proxy for all connections. When I try to connect to 192.168.0.1, I see the busy animation, and when it times-out I get the error message from my ISP's proxy. This is for an address that is in the bypass field, and is correctly bypassed by Safari and not Firefox. Also, I have tried changing the field to ".local, 169.254.0.0/16, 192.168.0.0/16" to match the example in the Firefox preferences, but this doesn't work either.

Firefox might also need some sort of translation for this field too, because it's clear to me that the MacOS X syntax for proxy bypass is different to the Firefox syntax. It's not hard to change either, but it does mean that it doesn't work out-of-the-box.

I can confirm that Firefox, when configured to use the System proxy settings, does not honour the System bypass settings, on MacOS X 10.5.6.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Confirming based on comment 3

Josh: can you look at this? Reportedly a regression in beta 4.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Perhaps nsOSXSystemProxySettings::IsInExceptionList is broken?

Comment 6

[Josh Aas]

I can reproduce, I'll take a look.

Comment 7

[Josh Aas]

Removing regression keyword, this stuff almost certainly never worked in system proxy mode. The code that is choking has been around since we added system proxy usage.

I set up a bogus proxy address and excepted "*.google.com" to test this. Safari let me access google.com, Firefox did not. This is because in Firefox (nsOSXSystemProxySettings.mm) we check the proxy exception by comparing the strings "google.com" (from Firefox networking) and "*.google.com" from the OS exception list. That comparison fails, so you can't access google.com. You can fix this by just writing "google.com" in the OS exceptions text field.

We need to make our domain comparison code smarter, probably include support for "*" and the "/" syntax.

Comment 8

[Josh Aas]

I stole the Windows code and it works better, but the Windows code isn't very smart either...

If your exception is "google.com" you can't load subdomains like "www.google.com" and if your exception is "*.google.com" you can't load just "google.com". Very literal. In IE on Windows if your exception is "*.google.com" you can still load "google.com".

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Not blocking since it's not a regression, but can we see the partial patch that you're working up?

Comment 10

[Josh Aas]

Attachment: fix v0.8

This is the gist of it so far, didn't have time to finish today. This needs closer inspection, a port comparison on Mac OS X, and more testing.

Comment 11

[Josh Aas]

Attachment: fix v1.0

Comment 12

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/1671b6e69007

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 376056 [details] [diff] [review]
fix v1.0

a191=beltzner

Comment 14

[Josh Aas]

pushed to mozilla-1.9.1

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d5a1a75a42d7

Comment 15

[Constantine V. Sokolov]

many thanx,
but half year for this little bug..