470209 - intl.charsetmenu.browser.unicode should not be included in localizable file

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Masatoshi Kimura [:emk]]

Quote from intl.properties:
> # Localization Note: Never change the following entry.
> intl.charsetmenu.browser.unicode=UTF-8, UTF-16LE, UTF-16BE, UTF-32LE, UTF-32BE
If it is not localizable, it should not be here in the first place.
This makes it harder to fix the bug such as bug 335531 or bug 441876.

Comment 1

[Axel Hecht [:Pike]]

Yes. I think for non-unicode encodings, it makes limited sense to have those localizable, but not really for the unicode section.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Make intl.charsetmenu.browser.unicode non-localizable [Checkin: Comment 6]

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 353671 [details] [diff] [review]
Make intl.charsetmenu.browser.unicode non-localizable
[Checkin: Comment 6]

sr=dbaron

Comment 4

[Masatoshi Kimura [:emk]]

Axel, would you announce removing the lines from intl.proeprties after pushed to trunk?

Comment 5

[Axel Hecht [:Pike]]

An announcement is only necessary for strings that changed without their keyname changing. Removing strings is going to trigger notifications by the build system.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 353671 [details] [diff] [review]
Make intl.charsetmenu.browser.unicode non-localizable
[Checkin: Comment 6]

http://hg.mozilla.org/mozilla-central/rev/193f1e225319