nsMsgNewsFolder::UpdateSummaryFromNNTPInfo leaves .msf files open

RESOLVED FIXED in Thunderbird 3.0b2

Status

MailNews Core
Backend
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

Trunk
Thunderbird 3.0b2
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 353678 [details] [diff] [review]
proposed fix

nsMsgNewsFolder::UpdateSummaryFromNNTPInfo is called when we update counts for newsgroups, and it can open all the .msf files for all the subscribed groups on a server, and leave them open. If you subscribe to large groups like the ones on news.mozilla.org, this can consume large amounts of memory. The upcoming patch checks if we opened the db, and if so, close it.

Ideally, we would have some sort of idle time cleaning up of cached folder db's, but even so, I think we'd want this code because otherwise we'll open a bunch of db's all at once, and leave them open for some period of time.
Attachment #353678 - Flags: superreview?(bugzilla)
Attachment #353678 - Flags: review?(Pidgeot18)
Comment on attachment 353678 [details] [diff] [review]
proposed fix

I'm not sure how this bug impacts my work on bug 311774, but the burden is on me to worry about this sort of stuff in that bug anyways.

I don't see any problems here.
Attachment #353678 - Flags: review?(Pidgeot18) → review+
Attachment #353678 - Flags: superreview?(bugzilla) → superreview+
(Assignee)

Updated

9 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Target Milestone: --- → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.