Closed
Bug 470219
Opened 17 years ago
Closed 17 years ago
nsMsgNewsFolder::UpdateSummaryFromNNTPInfo leaves .msf files open
Categories
(MailNews Core :: Backend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b2
People
(Reporter: Bienvenu, Assigned: Bienvenu)
Details
Attachments
(1 file)
|
1.15 KB,
patch
|
jcranmer
:
review+
standard8
:
superreview+
|
Details | Diff | Splinter Review |
nsMsgNewsFolder::UpdateSummaryFromNNTPInfo is called when we update counts for newsgroups, and it can open all the .msf files for all the subscribed groups on a server, and leave them open. If you subscribe to large groups like the ones on news.mozilla.org, this can consume large amounts of memory. The upcoming patch checks if we opened the db, and if so, close it.
Ideally, we would have some sort of idle time cleaning up of cached folder db's, but even so, I think we'd want this code because otherwise we'll open a bunch of db's all at once, and leave them open for some period of time.
Attachment #353678 -
Flags: superreview?(bugzilla)
Attachment #353678 -
Flags: review?(Pidgeot18)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 353678 [details] [diff] [review]
proposed fix
I'm not sure how this bug impacts my work on bug 311774, but the burden is on me to worry about this sort of stuff in that bug anyways.
I don't see any problems here.
Attachment #353678 -
Flags: review?(Pidgeot18) → review+
|
||
Updated•17 years ago
|
Attachment #353678 -
Flags: superreview?(bugzilla) → superreview+
|
Assignee | |
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•17 years ago
|
Target Milestone: --- → Thunderbird 3.0b2
You need to log in
before you can comment on or make changes to this bug.
Description
•