470269 - creating root imap folder ignores personal namespace

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[David :Bienvenu]

Attachment: proposed fix

If you have an imap account where "INBOX." is the personal namespace, meaning all folders are sub-folders of the INBOX, and you try to create a root level folder, we fail silently. We should be respecting the personal namespace and use that as the parent folder.

Neil, if you don't have an account like this, can you switch the review request to Standard8?

Comment 1

[David :Bienvenu]

this is needed for creating the archives folder correctly.

Comment 2

[[e-mail]]

Comment on attachment 353699 [details] [diff] [review]
proposed fix

>+  if (onlineDir.IsEmpty() && ns)
>+    onlineDir = ns->GetPrefix();
I don't have an account with a prefix or a non-standard delimiter but it seems to me that onlineDir uses /s while GetPrefix uses the server's delimiter?

Comment 3

[David :Bienvenu]

onlineDir uses the server delimiter as well (or at least, that's how I've always specified it, e.g., "INBOX."). I have an account that uses "." as the delimiter, and makes all folders be sub-folders of the inbox, and this works fine...

Comment 4

[[e-mail]]

I was just scared by this line later on that you can't see in the diff:

onlineDirWithDelimiter.ReplaceChar('/', delimiter);

Comment 5

[David :Bienvenu]

(In reply to comment #4)
> I was just scared by this line later on that you can't see in the diff:
> 
> onlineDirWithDelimiter.ReplaceChar('/', delimiter);

Right, I think that just makes it so you can use the canonical delimiter, and we'll fix it for you, but users really shouldn't have to know about our canonical delimiter.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 353699 [details] [diff] [review]
proposed fix

>+  nsIMAPNamespace *ns = nsnull;
>+  rv = hostSessionList->GetNamespaceForMailboxForHost(m_serverKey.get(),
>+    onlineMailboxName, ns);
>+  if (!ns)
>+     hostSessionList->GetDefaultNamespaceOfTypeForHost(m_serverKey.get(), kPersonalNamespace, ns);

nit: I know its copy and paste, but seeing as we're here. Can you align the onlineMailboxName with the m_serverKey, and also wrap the GetDefaultNamespaceOfTypeForHost in the same way please?

Comment 7

[David :Bienvenu]

fix checked in, with nits addressed