470275 - Fullscreen on full-size, non-maximized window doesn't hide title bar

Status: RESOLVED DUPLICATE of bug 196714

(Core :: General, defect)

Description

[Eric Searcy]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.5) Gecko/2008121621 Ubuntu/8.04 (hardy) Firefox/3.0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2

A regression in full screen handling which occurs in Firefox 3.1b2 (it works in 3.0.*).  Tested in Windows XP.  If you have a non-maximized window which is the same dimensions as the screen area and you press F11, Firefox switches to the full screen layout but leaves the title bar and window border visible on top of the Firefox display elements.

Easiest way to get a "non-maximized window which is the same dimensions as the screen area" is to close the browser with ALT-F4 while in full-screen mode.

Reproducible: Always

Steps to Reproduce:
1. Open Fx 3.1b2
2. Hit F11 to go fullscreen.
3. Press ALT-F4 for browser to close.
4. Open Fx 3.1b2.  Window should completely fill to edge of screen, but the window manager decorations imply that it isn't maximized (still has border, show maximize as opposed to restore button).
5. Press F11.
Actual Results:  
Firefox switches to fullscreen, but window manager decorations are overlaid on top.

Expected Results:  
Firefox switches to fullscreen and window manager decorations (title bar and border) are hidden (as in all other versions of Fx).

* Windows XP theme: classic.
* OS default setting of "Keep taskbar on top of other windows" is checked.
* No extensions installed.
* Default setting for browser.fullscreen.autohide (true)

Comment 1

[Nochum Sossonko [:Natch]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20081218 Shiretoko/3.1b3pre
Can't reproduce this locally using 3.1 latest-trunk, then again I'm using Vista, will try later today on XP.

Comment 2

[Eric Searcy]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090108 Minefield/3.2a1pre
Did you have a chance to try on XP, classic theme?

I've confirmed I get the same results on the latest-trunk.

Comment 3

[Eric Searcy]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1) Gecko/2008072310 Shiretoko/3.1a1
Actually, the above was with 3.2, sorry for the extra email.  It looks like latest-trunk for 3.1 doesn't reproduce this bug for me.

Comment 4

[Nochum Sossonko [:Natch]]

(In reply to comment #3)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1) Gecko/2008072310
> Shiretoko/3.1a1
That's not 3.1 latest-trunk, here's where to get it ftp://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-1.9.1/

>Did you have a chance to try on XP, classic theme?
No, I'm sorry I didn't have a chance. I'll try again tonight though ;) . This really needs to get categorized correctly, problem is I'm not sure where it really belongs...

Comment 5

[Eric Searcy]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090108 Shiretoko/3.1b3pre

D'oh, silly me.  Thanks for noticing that.  *Confirmed* on the above on XP Pro, classic desktop, with a vanilla user profile.

/me goes to get his morning coffee before touching the computer any more

Comment 6

[Nochum Sossonko [:Natch]]

Ok, so I can't reproduce this with your str on WinXP either (although I'm running on a VM so that could be worth nothing). However on Vista there's a weirdness when I hit f11, then hit it again. The taskbar on Vista remains hidden. Additionally, anytime I hit f11 on Vista, if the app isn't fully maximized I get some chrome artifacts, both are reproducible on other branches as well, however. I'm gonna put this in Core->General for better triage.

Comment 7

[Alexey Anatskiy]

I can confirm this is a problem on the latest nightly on WinXP <<Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090211 Shiretoko/3.1b3pre>>

Actually it's a much older problem - i'm having it now on 3.0.6 <<Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6>> and I had it on all 3.0.x, 2.0.x, possibly since full-screen was first implemented.

I'm seeing it reliably, i.e. every single time, on both of my machines WinXP Pro & WinXP Home.

Creating New profile and/or starting with no addons gives the same results.

For what it's worth, my settings are opposite no Eric's i.e. 
* Windows XP theme: STANDARD (Windows XP).
* OS default setting of "Keep taskbar on top of other windows" is UNCHECKED.
* NON-Default setting for browser.fullscreen.autohide (FALSE)

Comment 8

[(mostly gone) XtC4UaLL [:xtc4uall]]

i cannot repro comment 0 neither with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090316 Shiretoko/3.1b4pre ID:20090316095712
nor
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090316 Minefield/3.2a1pre ID:20090316044350

using Windows XP/Classic.

@comment 6 & comment 7: eventually file new bugs to those issues since they're different to the reporter's one. thanks!

Comment 9

[(mostly gone) XtC4UaLL [:xtc4uall]]

possibly dupe of bug 196714?
(run attachment mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=196714#c2 + f11/fullscreen)

Comment 10

[Eric Searcy]

@XtC4UaLL: you're right, bug 196714 is describing the same issue as my comment 0 - I just didn't find that one when I was looking for prior dupes before posting because I was restricting my searches to this branch, and older versions *didn't* repro this issue for me (see comment 3, where I was on 2008072310 and the problem went away, but then came back when I went to 20090108--same profile!).

This is yet more bizarre, because on the 20090316 1.9.1 nightly, the problem is there on my old (reasonably unchanged from dist) profile, and a newly created profile does *not* exhibit the comment 0 behavior.  *But*, this issue is still clearly that of bug 196714, because the difference between the two profiles is actually what the window dimensions are when started after closing while in fullscreen.  With the new profile, the un-maximized window is at (0,0) but the bottom of the window is above the taskbar, when started with the other firefox profile, the window is at (0,0) with the bottom of the window *behind* the taskbar at the bottom of the screen (size equal to screen resolution).  Bizarre.

(This is the same Windows user btw, just using -profilemanager to go back in forth between two profiles without changing anything in the OS).

I'll let somebody with more Bugzilla knowledge go ahead and close/mark this as dupe if that's the right course.  I wish I had more time to try and dig up more on this because I deal with kiosks where people close fullscreen windows and then immediately go fullscreen again when they open it up, meaning this bug can show up.  But I have no time this month! :-/