470357 - view source window no longer reads from cache (does loads twice, broken for POST)

Status: RESOLVED DUPLICATE of bug 469302

(Toolkit :: View Source, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is a regression from bug 17612.  We do the loadPage, then start doing the session history munging, and get an exception from addEntry (no such method). We silently ignore the exception and leave loadFromURL as true, and then just load it again.

This means that view-source doesn't work on POST pages anymore, doesn't read from cache on no-store or SSL no-cache pages (e.g. bug pages), etc.

I suspect the issue is that this code needs to QI the sessionHistory to nsISHistoryInternal to get the method it wants.  But we should probably also set loadFromURL to false right after returning from the loadPage call, consider not eating exceptions from the session history munging (or something), and add some tests to make sure this doesn't happen again.  The POST issue in particular should be reasonably straightforward to test, if we have an HTTP server available in our browser-chrome or browser tests.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Oh, and fwiw if you set a breakpoint in nsHttpChannel::AsyncOpen you can clearly see it being called twice when doing view-source.  The first time it hits the cache and comes from loadPage; the second time it's the loadURI call.