Closed Bug 470375 Opened 16 years ago Closed 16 years ago

1150->1200 SS perf loss due to extra inlining cost in patch for bug 470300

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: brendan, Assigned: gal)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 2 obsolete files)

working patch, thanks to danderson's gdb awesomeness
12.77 KB, patch
dvander
: review+
Details | Diff | Splinter Review
Fix anon. /be
Blocking per take-no-prisoners regression policy. /be
Flags: blocking1.9.1?
New idea. Atomize rp stack content. Store the 5-word blob in the lirbuffer and then emit a pointer to that blob onto the rp stack, instead of the actual blob content. Saves us 4 stores and is not invasive. Stealing from brendan (with permission, per don't-steal-from-brendan-or-else policy).
Assignee: brendan → gal
Attached patch patch, crashing on trace-test.js (obsolete) — — Splinter Review
Attached patch crashes a bit less (obsolete) — — Splinter Review
Attachment #353784 - Attachment is obsolete: true
Attachment #353785 - Attachment is obsolete: true
Attachment #353788 - Flags: review?(brendan)
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P1
Blocks: 471822
Attachment #353788 - Flags: review?(brendan) → review?(danderson)
I get 1128 as best score with this patch.
Attachment #353788 - Flags: review?(danderson) → review+
http://hg.mozilla.org/tracemonkey/rev/6bbf10f75a88
Whiteboard: fixed-in-tracemonkey
This test went orange. Doesn't look related. *** 661 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/toolkit/content/tests/chrome/test_bug418874.xul | undo correctly enabled when emptyText was not changed through property
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Robert, it would be nice if you could point to the hg changeset in each tracemonkey bug which has been merged to mozilla-central. This would save QA a lot of work. Thanks.
Whiteboard: fixed-in-tracemonkey
Target Milestone: mozilla1.9.1b3 → mozilla1.9.2a1
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: