Closed Bug 470410 Opened 13 years ago Closed 13 years ago

Implement basic protocol handler tests for IMAP and News protocols.

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

Attached patch The fixSplinter Review
As I said before, as part of the mailnews transfer to toolkit password manager, I'm implementing tests to check we're doing the protocol handling right. This means I know its working, and that we're not going to be hitting regressions in these areas at least.

Here's the tests for the IMAP and News protocols. I also renamed one function to better describe what it actually does.
Attachment #353802 - Flags: review?(neil)
Comment on attachment 353802 [details] [diff] [review]
The fix

Neil's forgotten how to get his cross-compiled build to run tests ;-)
Attachment #353802 - Flags: review?(neil) → review?(bienvenu)
Comment on attachment 353802 [details] [diff] [review]
The fix

I have a test failure, but it seems to happen w/ and w/o this patch. I'll attach it in a sec.
Attachment #353802 - Flags: review?(bienvenu) → review+
Attached file log of test failure
Attachment #353837 - Attachment mime type: application/octet-stream → text/plain
Not sure what the test failure is/was, but this has stuck on the tinderboxes:

http://hg.mozilla.org/comm-central/rev/439529319157
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.