Closed Bug 470461 Opened 16 years ago Closed 16 years ago

[FIX]Create frames for XBL that's security-blocked (1.8 branch only).

Categories

(Core :: XBL, defect)

1.8 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

(Keywords: regression, verified1.8.1.21)

Attachments

(1 file)

Attached patch Like soSplinter Review
See bug 470049 comment 10. I'd rather not change this on trunk and 1.9.0 since things work ok there, and if I were changing it there I'd want a much more comprehensive change anyway (e.g. explicitly signaling that the XBL load started and signaling if it fails).
Attachment #353858 - Flags: superreview?(jonas)
Attachment #353858 - Flags: review?(jonas)
Attachment #353858 - Flags: approval1.8.1.next?
Comment on attachment 353858 [details] [diff] [review] Like so Though I thought that 1.8.1.20 was out the door already, and that that was the last release?
Attachment #353858 - Flags: superreview?(jonas)
Attachment #353858 - Flags: superreview+
Attachment #353858 - Flags: review?(jonas)
Attachment #353858 - Flags: review+
It's the last Firefox release, not the last browser release off the 1.8 branch. Both camino and seamonkey will still be shipping 1.8-based Geckos for a few months.
OS: Mac OS X → All
Hardware: x86 → All
Version: Trunk → 1.8 Branch
For whatever it's worth, Firefox 2.0.0.21pre nightlies are still being published, so it's not totally impossible that this fix will even find its way into a BonEcho (i.e. Fx2) nightly before that branch is actually chopped off.
Comment on attachment 353858 [details] [diff] [review] Like so Approved for 1.8.1.21, a=dveditz for release-drivers.
Attachment #353858 - Flags: approval1.8.1.next? → approval1.8.1.next+
Flags: wanted1.9.0.x+
Flags: blocking1.9.0.7+
Keywords: regression
Flags: wanted1.9.0.x+
Flags: wanted1.8.1.x+
Flags: blocking1.9.0.7+
Flags: blocking1.8.1.next+
Checked in on 1.8 branch.
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: fixed1.8.1.21
Resolution: --- → FIXED
Verified (the password field shows up again on the Wells Fargo home page) in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.8.1.21pre) Gecko/20090120 Camino/1.6.7pre (like Firefox/2.0.0.21pre) Thanks bz!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: