470507 - Ext Manager in Fennec logs errors on every startup

Status: RESOLVED DUPLICATE of bug 465190

(Toolkit :: Add-ons Manager, defect)

Description

[(dormant account)]

On my device i got 124K of log within the last 4 days, but I guess I start fennec frequently.

It's always the same 2 "errors"

2008-12-15 12:27:31 - DirectoryInstallLocation: failed to create location  directory = /home/taras/work/ff-build.fennec.flat/mobile/dist/bin/extensions, exception = [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsILocalFile.create]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: file:///home/taras/work/ff-build.fennec.flat/xulrunner/dist/bin/components/nsExtensionManager.js :: DirectoryInstallLocation :: line 1104"  data: no]

2008-12-15 12:27:31 - DirectoryInstallLocation: failed to create location  directory = /usr/share/mozilla/extensions/{a23983c0-fd0e-11dc-95ff-0800200c9a66}, exception = [Exception... "Component returnedfailure code: 0x80004005 (NS_ERROR_FAILURE) [nsILocalFile.create]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///home/taras/work/ff-build.fennec.flat/xulrunner/dist/bin/components/nsExtensionManager.js :: DirectoryInstallLocation :: line 1104"  data: no]


It tries to create the above directories which seems wrong as they are in the app dir.

Comment 2

[(dormant account)]

I propose we add a "system" param to DirectoryInstallLocation in which case it wouldn't try to create the directory

Comment 3

[(dormant account)]

also why not open the log file without the append flag? Seems healthier than eating away at disk space

Comment 4

[Dave Townsend [:mossop]]

(In reply to comment #3)
> also why not open the log file without the append flag? Seems healthier than
> eating away at disk space

The log file is important for spotting what an original error was that is causing a problem a user is seeing later. Overwriting it each time basically loses us that information. It should only be being written to when there is a real critical problem so the general case is it won't ever get written to. We just need to clean up some places where errors are safe enough to ignore or avoid them altogether