470554 - Support homepage template broken, causing screwy lists.

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[[:Cww]]

http://support.mozilla.com/en-US/kb/

contains the following HTML for the list of Popular support articles:

<ul><li> <a title="This article covers why you would not be able to access any web sites after upgrading Firefox. You may instead get  quot;Unable to connect quot; or  quot;Server not found quot; error pages.
</li></ul>

<p>For situa" href='tiki-index.php?page=Cannot+connect+after+upgrading+Firefox' class='wiki'>Cannot connect after upgrading Firefox</a>
</p>
<ul><li> <a title="If bookmarks are missing, see Lost bookmarks.
</li></ul>
<p>If toolbar buttons are missing, see Back and forward or other toolbar buttons are missing.
</p>


<p>Windows:
<br />If bookmarks and toolbar buttons are working prope" href='tiki-index.php?page=Bookmarks+and+toolbar+buttons+not+working+after+upgrading' class='wiki'>Bookmarks and toolbar buttons not working after upgrading</a>
</p>
<ul><li> <a title="Private data is used by the browser to enhance your experience on the internet.  When the browser remembers a web site you previously visited or the username and password for your favorite web site," href='/en-US/kb/Clearing+Private+Data' class='wiki'>Clearing Private Data</a>

</li><li> <a title="Over time, the Search bar history in Firefox can grow quite large. If needed, you can clear items from the Search bar history.
</li></ul>


<p>To clear all items, right-clickhold down the Ctrl key while you click" href='tiki-index.php?page=How+to+clear+Search+bar+history' class='wiki'>How to clear Search bar history</a>
</p>
<ul><li> <a title="This article describes how to clear single items or all items from the Location bar history.
</li></ul>




<p>Table Of ContentsClearing a single item from the Location bar history
<br />Clearing all items in the Locati" href='tiki-index.php?page=Clearing+Location+bar+history' class='wiki'>Clearing Location bar history</a>
</p>
<ul><li> <a title="This article identifies several causes (and solutions) of No Sound in Firefox.
</li></ul>


<p>Before using the instructions in this article, make sure other applications on your computer can play sounds. If Firef" href='tiki-index.php?page=No+sound+in+Firefox' class='wiki'>No sound in Firefox</a>

...

Basically now that we have tooltips that provide titles, there's a " missing or misplaced somewhere.  Should be an easy fix.

Comment 1

[E. Cooper [:ecooper]]

Can someone with access rights on prod attach the wiki text used in the content blocks for the "New to Firefox?" and "Popular Support Articles" blocks? While there is a chance it's probably not the problem, I need the most current version to troubleshoot.

Comment 2

[Chris Ilias [:cilias]]

New to Firefox:
-------------------------
* ((Installing Firefox))
* ((Using Firefox))
* ((Customizing Firefox with add-ons))
-------------------------


Popular Support articles:
-------------------------
* ((Cannot connect after upgrading Firefox))
* ((Bookmarks and toolbar buttons not working after upgrading))
* ((Clearing Private Data))
* ((How to clear Search bar history))
* ((Clearing Location bar history))
* ((No sound in Firefox))
* ((Exporting bookmarks to an HTML file))
* ((Keyboard shortcuts))
* ((How to make Firefox the default browser))
* ((Organizing Bookmarks))
-------------------------

Comment 3

[Chris Ilias [:cilias]]

FWIW, it isn't just content blocks or the home page. It's lists in general. See:
http://support.mozilla.com/en-US/kb/Error+loading+web+sites
http://support.mozilla.com/en-US/kb/Cannot+connect+after+upgrading+Firefox

Comment 4

[E. Cooper [:ecooper]]

I can't replicate the broken lists on my dev instance (I get the same descriptions with the html inside, however), which is sort of confusing and frustrating.

After looking over a bit of parser code, it seems that the link titles are page descriptions being pulled straight from the tiki_pages table. So, if that description contains anything it shouldn't, it might be causing the broken lists. It can be either messing with the rest of the parsing process (as links are transformed into html before lists are generated) or just causing malformed html.

Sanitizing the description should fix this.

Comment 5

[E. Cooper [:ecooper]]

Actually, it looks like newlines in the description that's used for the link title are messing with the parser (which parses one line at a time).

Comment 6

[Chris Ilias [:cilias]]

Yup, I tried rearranging the list items on <http://support.mozilla.com/en-US/kb/Article+Sandbox?bl=n>, and it does seem specific to certain articles. For instance, Anything after ((How to clear Search bar history)) is a sublist. Same goes for ((Clearing Location bar history)).

Comment 7

[E. Cooper [:ecooper]]

Attachment: Makes sure that no newlines are in page descriptions when they are used as link titles

This seems to do the trick. It isn't the most ideal method, but it's the most backward compatible (although, it seems page_exists_desc is only used where it needed to be changed anyway so that issue might be moot).

Comment 8

[Nelson Ko [:nkoth]]

Normally line breaks should not appear in TikiWiki descriptions. I think the line breaks in the description was caused by the auto-description-generation of the new search indexing. 

I suggest instead of adding complexity into tikilib, that we simply fix the indexer to strip line breaks from the auto-generated description, and force a new index from scratch.

On development, I deleted lastindexingtime.txt (to force a clean indexing) and then ran the "php manual_index.php" from the command line, and that did the trick.

We should be running the index procedure as part of 0.8.1 deployment anyway, since we are fixing bug 470550 in the process as well.

Comment 9

[Nelson Ko [:nkoth]]

Attachment: strip line breaks from generated description

Comment 10

[E. Cooper [:ecooper]]

I agree with Nelson that this is the best way to fix this bug. 

Prior to our talk, I was under the impression that descriptions were used more often and in different ways. They have a pretty singular use, however.

Comment 11

[Nelson Ko [:nkoth]]

in r21499/r21500. Still need reindexing to be run.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #11)
> in r21499/r21500. Still need reindexing to be run.

Shouldn't we assign this to, or cc, at least, ops, then?

Comment 13

[Laura Thomson :laura]

What we do is add "run reindexing" to the push bug and close this one.

Comment 14

[E. Cooper [:ecooper]]

(In reply to comment #13)
> What we do is add "run reindexing" to the push bug and close this one.

That is done, so closing this one for now.

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #14)
> (In reply to comment #13)
> > What we do is add "run reindexing" to the push bug and close this one.
> 
> That is done, so closing this one for now.

Why didn't that fix the homepage when we pushed last night?

http://support.mozilla.com/en-US/kb/Firefox+Support+Home+Page

Comment 16

[Chris Ilias [:cilias]]

I brought this up just after the push last night, and was told that there needs to be a reindexing on new search for this to take affect.

Comment 17

[[:Cww]]

Still happens on staging so it's not completely fixed:

http://support-stage.mozilla.org/kb/

Comment 18

[Laura Thomson :laura]

We still haven't run indexing, and won't until Nelson can make it work right.

Comment 19

[Nelson Ko [:nkoth]]

Will create another IT bug to get indexing done. Everything is ready - just need to write the instructions.

Comment 20

[Nelson Ko [:nkoth]]

Will arrange for this to be done by IT on another different night after the 0.8.2 push.

(In reply to comment #19)
> Will create another IT bug to get indexing done. Everything is ready - just
> need to write the instructions.

Comment 22

[E. Cooper [:ecooper]]

Re-indexing has finally happened, marking this as fixed.

Comment 23

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on both staging:

http://support-stage.mozilla.org/en-US/kb/

and production:

http://support.mozilla.com/en-US/kb/