Closed
Bug 470573
Opened 17 years ago
Closed 17 years ago
Change "Remove Reports" to "Remove All Reports"
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: tdowner, Assigned: tdowner)
Details
Attachments
(2 files)
|
765 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
|
1.19 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
To emphasize the fact that this will remove ALL reports, and you will not be able to simply pick and choose. In conjunction with the pop-up dialog, this will help those who are somewhat illiterate.
|
Assignee | |
Updated•17 years ago
|
Attachment #353987 -
Flags: review? → review?(vladimir)
|
|
Assignee | |
Updated•17 years ago
|
Version: unspecified → Trunk
|
|
||
Comment 2•17 years ago
|
||
Comment on attachment 353987 [details] [diff] [review]
V1
[Checkin: Comment 6]
Ted's actually the right reviewer for this.
And, not that you've requested it, but we probably shouldn't take this string change in 3.1 since it's non-critical.
Attachment #353987 -
Flags: review?(vladimir) → review?(ted.mielczarek)
|
|
Assignee | |
Comment 3•17 years ago
|
||
totally agree. I don't see a need for this in any specific release, just sometime.
|
||
Comment 4•17 years ago
|
||
Comment on attachment 353987 [details] [diff] [review]
V1
[Checkin: Comment 6]
Doesn't matter terribly much to me, that's fine.
Attachment #353987 -
Flags: review?(ted.mielczarek) → review+
|
||
Comment 6•17 years ago
|
||
Comment on attachment 353987 [details] [diff] [review]
V1
[Checkin: Comment 6]
http://hg.mozilla.org/mozilla-central/rev/77a854777ce2
Attachment #353987 -
Attachment description: V1 → V1
[Checkin: Comment 6]
|
|
||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
||
Comment 7•17 years ago
|
||
The patch should look like this, otherwise localizers won't catch this change.
Attachment #354444 -
Flags: review?(ted.mielczarek)
|
|
||
Updated•17 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 8•17 years ago
|
||
Comment on attachment 354444 [details] [diff] [review]
change key name
[Checkin: Comment 10]
Oops, sorry, can't believe I missed that!
Attachment #354444 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 9•17 years ago
|
||
Thanks Valdo, didn't notice that.
|
|
Assignee | |
Updated•17 years ago
|
Attachment #353987 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
|
||
Comment 10•17 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
|
|
||
Comment 11•17 years ago
|
||
Comment on attachment 353987 [details] [diff] [review]
V1
[Checkin: Comment 6]
Don't obsolete checked-in patches.
Attachment #353987 -
Attachment is obsolete: false
|
|
||
Updated•17 years ago
|
Attachment #354444 -
Attachment description: change key name → change key name
[Checkin: Comment 10]
|
||
Comment 12•17 years ago
|
||
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20081227 Minefield/3.2a1pre ID:20081227020350
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•