470574 - Warnings in nsCaret.cpp

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Simon Montagu :smontagu]

Attachment: Patch

From Bug 418513 comment 35:

This introduced a new warning:

layout/base/nsCaret.h:311: 'nsCaret::mLastHint' will be initialized after
layout/base/nsCaret.h:295:    'PRPackedBool nsCaret::mIgnoreUserModify'
layout/base/nsCaret.cpp:89:   when initialized here

I get another new warning:

layout/base/nsCaret.h:301: 'nsCaret::mLastBidiLevel' will be initialized after
layout/base/nsCaret.h:298:    'PRPackedBool nsCaret::mKeyboardRTL'
layout/base/nsCaret.cpp:89:    when initialized here

and an old one:

layout/base/nsCaret.cpp: In function 'PRBool DrawCJKCaret(nsIFrame*, PRInt32)':
layout/base/nsCaret.cpp:180: comparison between signed and unsigned integer expressions.

The attached patch fixes all of them.

Comment 1

[Simon Montagu :smontagu]

Comment on attachment 353986 [details] [diff] [review]
Patch

...roc is away

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 353986 [details] [diff] [review]
Patch

r+sr=dbaron, although:

 1. if you care about the possibility that the fragment's length is in [2^31,2^32), you might want to cast aOffset to PRUint32 instead.  (You've already checked it's >= 0, so that's fine.)

 2. In C++, I'd slightly prefer a construction-style cast, i.e., PRInt32(aOffset) rather than (PRInt32)aOffset.

Comment 3

[Simon Montagu :smontagu]

Pushed with the suggested changes: http://hg.mozilla.org/mozilla-central/rev/97765537869e

Comment 4

[Simon Montagu :smontagu]

Forgot to mark this fixed.