Closed Bug 470623 Opened 17 years ago Closed 17 years ago

Change the property name WARN_UNSUPPORTED_MSG to WARN_MIN_SUPPORTED_OS_MSG

Categories

(Calendar :: Sunbird Only, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(1 file)

Attached patch patch rev1Splinter Review
The name is incorrect so we might as well clean it up.
Attachment #354024 - Flags: review?(ctalbert)
Why not keep the same name in all products? WARN_UNSUPPORTED_MSG is used in firefox, thunderbird and seamonkey too: http://mxr.mozilla.org/comm-central/search?string=WARN_UNSUPPORTED_MSG
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #354024 - Attachment is obsolete: true
Attachment #354024 - Flags: review?(ctalbert)
It isn't terribly important... I will likely be changing Firefox's property name on trunk due to wanting to change MinUnsupportedVer to MinSupportedVer and initially wanted to sync Sunbird but in the end it isn't necessary for them to be in sync
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
We want this patch to stay in sync with Firefox and Thunderbird (where this fix has already landed)! Sorry, Robert!
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Attachment #354024 - Attachment is obsolete: false
Attachment #354024 - Flags: review?(ctalbert)
Attachment #354024 - Flags: review?(ctalbert) → review+
Comment on attachment 354024 [details] [diff] [review] patch rev1 r=ctalbert Looks good. Merry Christmas :-)
Status: REOPENED → RESOLVED
Closed: 17 years ago17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: