Closed
Bug 470623
Opened 17 years ago
Closed 17 years ago
Change the property name WARN_UNSUPPORTED_MSG to WARN_MIN_SUPPORTED_OS_MSG
Categories
(Calendar :: Sunbird Only, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
Attachments
(1 file)
|
2.85 KB,
patch
|
cmtalbert
:
review+
|
Details | Diff | Splinter Review |
The name is incorrect so we might as well clean it up.
Attachment #354024 -
Flags: review?(ctalbert)
Comment 1•17 years ago
|
||
Why not keep the same name in all products?
WARN_UNSUPPORTED_MSG is used in firefox, thunderbird and seamonkey too:
http://mxr.mozilla.org/comm-central/search?string=WARN_UNSUPPORTED_MSG
Updated•17 years ago
|
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
| Assignee | ||
Updated•17 years ago
|
Attachment #354024 -
Attachment is obsolete: true
Attachment #354024 -
Flags: review?(ctalbert)
| Assignee | ||
Comment 2•17 years ago
|
||
It isn't terribly important... I will likely be changing Firefox's property name on trunk due to wanting to change MinUnsupportedVer to MinSupportedVer and initially wanted to sync Sunbird but in the end it isn't necessary for them to be in sync
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
Comment 3•17 years ago
|
||
We want this patch to stay in sync with Firefox and Thunderbird (where this fix has already landed)! Sorry, Robert!
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Updated•17 years ago
|
Attachment #354024 -
Attachment is obsolete: false
Attachment #354024 -
Flags: review?(ctalbert)
Attachment #354024 -
Flags: review?(ctalbert) → review+
Comment on attachment 354024 [details] [diff] [review]
patch rev1
r=ctalbert Looks good. Merry Christmas :-)
| Assignee | ||
Comment 5•17 years ago
|
||
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/947a89d21624
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Comment 6•14 years ago
|
||
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•