470838 - Write 302 tests for imagelib

Status: RESOLVED INVALID

(Core :: Graphics: ImageLib, defect)

Description

[Joe Drew (not getting mail)]

Bug 89419 fixed imagelib's 302 behaviour, but it didn't add any tests. This is obviously a bad thing.

What will be necessary to fix this is both some form of server-side JS that implements the simple state machine required to switch out which image we're redirecting to (examples of this are source/toolkit/components/passwordmgr/test/authenticate.sjs for a 401 and modules/libpr0n/test/reftest/generic/check-header.sjs for checking other headers), as well as some reftest-alike structure that lets us compare the output - WindowUtils.js apparently has something that will be helpful.

Comment 1

[Joe Drew (not getting mail)]

Attachment: Mochitest for 302 images

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 354398 [details] [diff] [review]
Mochitest for 302 images

This patch doesn't work right now. (I suspect httpd.js changes.) I'll fix it and resubmit a new test.

Comment 3

[Jeff Walden [:Waldo]]

Probably bug 471158, but I don't see what would be causing a problem for you here, as you're not using your state outside of the single SJS file.  Changing the line in netwerk/test/httpserver/httpd.js that sets DEBUG to set it to true, making in testing/mochitest (I think) if you're on Windows, and running that Mochitest (use --test-path=modules/libpr0n/test/mochitest/test_bug89419.html with runtests.py or TEST_PATH=modules/libpr0n/test/mochitest/test_bug89419.html if you're going the make route to running tests) is likely to give useful console spew (to me at least, quite possibly to you as well, but I don't remember what output I'd have made here) for figuring out what's happening.

Comment 4

[Joe Drew (not getting mail)]

Attachment: Mochitest for 302 images

I am a moron. The reason it didn't work was because the Makefile.in part of the patch had been bitrotted by other testcases I'd added, and blue.png hadn't been copied in. It was a 404, and so onload never got fired on it.

Comment 5

[Joe Drew (not getting mail)]

The test in this bug is bogus, and I'm going to write a correct test as part of bug 552605.