470916 - ASSERTION: root view manager's default background isn't opaque on print preview

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

I get this assertion on print preview when I have the option "Print Background (Colors & Images)" checked in Page Setup:
###!!! ASSERTION: root view manager's default background isn't opaque: 'needTran
sparency || NS_GET_A(backgroundColor) == 255', file c:/mozilla-build-1.3/src/lay
out/base/nsPresShell.cpp, line 5397

Hg blame leads to the patch in bug 467459, so I guess that bug is responsible for this assertion.

Comment 1

[Zack Weinberg (:zwol)]

Attachment: patch

Here's a patch, which takes a "final" opaque color from the pres context if necessary.  I originally coded bug 467459 that way but roc didn't think it would be needed -- so maybe there's a better way to do this, but I don't know what it is.  With the patch I do not get the assertion.

Comment 2

[Zack Weinberg (:zwol)]

nom'ing for 1.9.1 - low risk (IMO) & eliminates an assertion.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

How does the root view manager get a non-opaque default background color in this case?

Comment 4

[Zack Weinberg (:zwol)]

This assertion was removed by bug 474201.