Closed Bug 470963 Opened 11 years ago Closed 11 years ago
stop copying build/pgo/certs to the objdir
We currently copy a bunch of files from build/pgo/certs to $(OBJDIR)/_profile/pgo/certs. I think this is a vestige from when we generated these files at build time. We should just point automation.py at the srcdir instead of copying these files around. We're going to need a separate fix for mobile and running tests on prepackaged builds anyway, I'll take care of that in another bug.
I got rid of obj-dir/_profile/pgo/certs dir. It is useless now, certificates (.ca, .p12 and .client) are all referred from the source directory.
Assignee: ted.mielczarek → honzab.moz
Attachment #355668 - Flags: review?(ted.mielczarek)
Attachment #355668 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 355668 [details] [diff] [review] v1 + -DPGO_DIR=\"$(_PROFILE_DIR)\" \ Can we not call this "PGO_DIR"? I'd like to move this stuff out of build/pgo eventually, since most of it has nothing to do with PGO and it's confusing. Other than that, looks fine. Thanks for patching this!
Ready to land
Attachment #355668 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Are there plans to land this on the 1.9.1 branch?
(In reply to comment #6) > Are there plans to land this on the 1.9.1 branch? This should also be landed after bug 456001.
Depends on: 456001
Target Milestone: --- → mozilla1.9.2a1
Attachment #361734 - Attachment description: v1.2 for 1.9.1 → v1.2 for 1.9.1 [Checkin: Comment 10]
Attachment #356022 - Attachment description: v1.1 → v1.1 [Checkin: Comment 5]
You need to log in before you can comment on or make changes to this bug.