470971 - add ability to pass GRE dir to xpcshell

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[(not currently active) Ted Mielczarek]

Currently you can't run xpcshell from a directory other than where components/ lives, because it expects to find those components alongside the executable. It should be possible to pass that path to xpcshell on the command line, so that you could run xpcshell from a different location.

Comment 1

[(not currently active) Ted Mielczarek]

Per IRC, bsmedberg says this is tricky because we init XPCOM before parsing the commandline in xpcshell. I agreed that if it simplifies things, I'm fine with requiring the option to be the first thing on the commandline.

Comment 2

[Benjamin Smedberg]

Attachment: -g <gredir> for xpcshell, rev. 1

This supports -g <gredir> for xpcshell.

You still have to do some munging of {LD,DYLD}_LIBRARY_PATH, in order to get all the libraries loaded correctly... I recommend not using run-mozilla.sh, because it messes with MOZILLA_FIVE_HOME and can get confused.

Comment 3

[Benjamin Smedberg]

Note, I'm still running this through tryserver... I'm a little anxious about whether all the libxul/non-libxul configurations will work correctly, but I think they will.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 357216 [details] [diff] [review]
-g <gredir> for xpcshell, rev. 1

Looks sane to me, but of course I'm not an XPConnect peer.

Comment 5

[(not currently active) Ted Mielczarek]

I have an updated patch for bug 460515, and it works great with this patch applied.

Comment 6

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/700bca4b693f

Comment 7

[Benjamin Smedberg]

Reopened due to Tunit bustage... it's somehow failing to get XpcomLib from the directory service, probably due to the xpcom directory being wrong somehow. I tried http://hg.mozilla.org/mozilla-central/rev/a563bc0ec80a but that didn't work.

Comment 8

[Kai Engert (:KaiE:)]

Just in case you haven't noticed, you backed out comment 6, but did not backout comment 7

Comment 9

[Benjamin Smedberg]

Attachment: -g <gredir> for xpcshell, rev. 1.1

The former patch was buggy because XRE_GetBinaryPath gives you the path of xpcshell.exe, and we really want the parent directory. This patch fixes, and also rebases against minor changes.

Comment 10

[(not currently active) Ted Mielczarek]

You never re-landed this, did you?

Comment 11

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/9a28db57d6a9

Comment 12

[(not currently active) Ted Mielczarek]

Pushed to 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/917e4f318003