470987 - Sunbird executable should have the manifest with requestedExecutionLevel="asInvoker"

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Robert Strong (they/them - no direct email)]

Spinoff of bug 378598 for Sunbird... I thought this was already done!

This will disable the folder virtualization, then some software update/installer related bugs will be fixed.

Comment 1

[Stefan Sitter [:ssitter]]

Is the solution from Bug 445545 not enough?
http://mxr.mozilla.org/comm-central/source/calendar/sunbird/app/MozillaSunbird.exe.manifest

Comment 2

[Robert Strong (they/them - no direct email)]

I suspect this is due to the manifest file not being named sunbird.exe.manifest... just recompiled with a sunbird.exe.manifest present and it had requestedExecutionLevel="asInvoker"

Without the sunbird.exe.manifest in place all I have is

<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
  <dependency>
    <dependentAssembly>
      <assemblyIdentity type="win32" name="Microsoft.VC80.CRT" version="8.0.50727.762" processorArchitecture="x86" publicKeyToken="1fc8b3b9a1e18e3b"></assemblyIdentity>
    </dependentAssembly>
  </dependency>
</assembly>

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

I believe this should do the trick... Firefox's splash.rc also references firefox.exe.manifest

Comment 4

[Robert Strong (they/them - no direct email)]

This really should be a priority to be fixed for the next release so requesting blocking so it doesn't fall to the wayside

Comment 5

[Stefan Sitter [:ssitter]]

Comment on attachment 354352 [details] [diff] [review]
patch rev1

untested but the change seems reasonable, r=ssitter

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/1bf15ea55295

Comment 7

[Robert Strong (they/them - no direct email)]

I verified this is now fixed using a tinderbox build from
http://ftp.mozilla.org/pub/mozilla.org/calendar/sunbird/tinderbox-builds/comm-central-sunbird-win32/1230149299/

The correct manifest exists in the sunbird.exe and the directories are no longer created under %LOCALAPPDATA%\VirtualStore\Program Files

Comment 8

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".