Closed Bug 471024 Opened 13 years ago Closed 13 years ago

Volume = 0 and muted = true dont make it silent

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: BijuMailList, Assigned: kinetik)

References

Details

(Keywords: regression, verified1.9.1)

Attachments

(2 files, 1 obsolete file)

Attached file volume.html
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) 
Gecko/20081223 Minefield/3.2a1pre
(May this is similar to Bug 470662)


See the attachment setting Volume = 0 and muted = true when we are about to play dont make it silent.

When we read status it still says volume = 0 and muted = true 

BTW: 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) 
Gecko/20081221 Shiretoko/3.1b3pre
works fine
Issue on Ubuntu also
OS: Windows XP → All
Hardware: x86 → All
Assignee: nobody → kinetik
Flags: blocking1.9.1?
Attached patch patch v0 (obsolete) — Splinter Review
Rename mMutedVolume to mVolume and use it to track the element's volume all the time.  Remove all the useless GetVolume calls from the decoders and audio stream.  Call decoder's SetVolume method in InitializeDecoderForChannel after it has been set up.
Attachment #364063 - Flags: superreview?(roc)
Attachment #364063 - Flags: review?(chris.double)
Attachment #364063 - Flags: superreview?(roc) → superreview+
Comment on attachment 364063 [details] [diff] [review]
patch v0

+  float oldVolume = mVolume;
+  mVolume = aVolume;
+
+  if (oldVolume != mVolume) {
+    if (mDecoder && !mMuted)
+      mDecoder->SetVolume(mVolume);

Avoid oldVolume by just writing "if (aVolume != mVolume) return NS_OK"?

Similar in SetMuted
Blocks: 464158
Attached patch patch v1Splinter Review
I guess you mean (aVolume == mVolume), but good point!
Attachment #364063 - Attachment is obsolete: true
Attachment #364065 - Flags: superreview+
Attachment #364065 - Flags: review?(chris.double)
Attachment #364063 - Flags: review?(chris.double)
Attachment #364065 - Flags: review?(chris.double) → review+
Pushed 9bdfe330b2aa.

I think we should take this fix on 1.9.1 as well.  It's a regression from the async loading patch, and the fix is trivial.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: blocking1.9.1? → blocking1.9.1+
Whiteboard: [needs 191 landing]
PASS
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) 
Gecko/20090228 Minefield/3.2a1pre

(thx, while testing this I found bug 480819)
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
rv:1.9.2a1pre) Gecko/20090413 Minefield/3.6a1pre
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre)
Gecko/20090413 Shiretoko/3.5b4pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.