471024 - Volume = 0 and muted = true dont make it silent

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Biju]

Attachment: volume.html

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) 
Gecko/20081223 Minefield/3.2a1pre
(May this is similar to Bug 470662)


See the attachment setting Volume = 0 and muted = true when we are about to play dont make it silent.

When we read status it still says volume = 0 and muted = true 

BTW: 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) 
Gecko/20081221 Shiretoko/3.1b3pre
works fine

Comment 1

[Biju]

Issue on Ubuntu also

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: patch v0

Rename mMutedVolume to mVolume and use it to track the element's volume all the time.  Remove all the useless GetVolume calls from the decoders and audio stream.  Call decoder's SetVolume method in InitializeDecoderForChannel after it has been set up.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 364063 [details] [diff] [review]
patch v0

+  float oldVolume = mVolume;
+  mVolume = aVolume;
+
+  if (oldVolume != mVolume) {
+    if (mDecoder && !mMuted)
+      mDecoder->SetVolume(mVolume);

Avoid oldVolume by just writing "if (aVolume != mVolume) return NS_OK"?

Similar in SetMuted

Comment 4

[Matthew Gregan [:kinetik]]

Attachment: patch v1

I guess you mean (aVolume == mVolume), but good point!

Comment 5

[Matthew Gregan [:kinetik]]

Pushed 9bdfe330b2aa.

I think we should take this fix on 1.9.1 as well.  It's a regression from the async loading patch, and the fix is trivial.

Comment 6

[Biju]

PASS
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) 
Gecko/20090228 Minefield/3.2a1pre

(thx, while testing this I found bug 480819)

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f46d052b6e4a

Comment 8

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
rv:1.9.2a1pre) Gecko/20090413 Minefield/3.6a1pre
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre)
Gecko/20090413 Shiretoko/3.5b4pre