471317 - m-c url on TB/m-c waterfall has the right rev, but points to 1.9.1

Status: VERIFIED FIXED

(Mozilla Messaging Graveyard :: Server Operations, defect)

Description

[Serge Gautherie (:sgautherie)]

Example:
{
TinderboxPrint: "<a href=http://hg.mozilla.org//releases/mozilla-1.9.1/index.cgi/rev/bc174f0cc10d title=\"Built from Mozilla revision bc174f0cc10d\">moz:bc174f0cc10d</a>"
}

Comment 1

[Serge Gautherie (:sgautherie)]

And maybe "moz:" should be changed back to "m-c:" too.

Comment 2

[Philippe M. Chiasson (:gozer)]

The unit-test (aka check) boxes should now be linking correctly.

Comment 3

[Philippe M. Chiasson (:gozer)]

Generally, if the links are correct, how valuable is it to have the distinction m-c vs. moz ?

It would be much simpler to always use, say, moz as the text of the link, but correctly link to the right place.

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> The unit-test (aka check) boxes should now be linking correctly.

Well, now: they have the m-c link :-) but the c-c rev :-(

(In reply to comment #3)
> how valuable is it to have the distinction m-c vs. moz ?

I don't know, I simply wanted to mention it.

Comment 5

[Philippe M. Chiasson (:gozer)]

Type fixed in change 

http://hg.mozilla.org/build/buildbot-configs/rev/dc283226fd2f

Comment 6

[Serge Gautherie (:sgautherie)]

Verified for the 'check' boxes :-)
Now, the 'bloat build' boxes need to use the same links.

While there, the box names on that page should be unified too:
after either '* comm-central *' or '* comm-central mozilla-central *'.


Actually, the TBv3.0 page has these "same" issues too...

Comment 7

[Philippe M. Chiasson (:gozer)]

(In reply to comment #6)
> Verified for the 'check' boxes :-)

Good, all 'check' boxes are under the same buildbot master, so they should all
behave the same.

> Now, the 'bloat build' boxes need to use the same links.

A different master, a different fix.

> While there, the box names on that page should be unified too:
> after either '* comm-central *' or '* comm-central mozilla-central *'.

The idea is to unify naming after the same pattern the 'check' boxes are following.

> Actually, the TBv3.0 page has these "same" issues too...

Yes, same buildbot master!

Comment 8

[Serge Gautherie (:sgautherie)]

And based on bug 472289, there's also the extra '/' issue to fix on a "per app" basis.

Comment 9

[Philippe M. Chiasson (:gozer)]

Removed extra '/'s

comparing with ssh://hg.mozilla.org/build/buildbot-configs
searching for changes
changeset:   712:f2ad7012ff63
tag:         tip
user:        Philippe M. Chiasson <[e-mail]>
date:        Fri Jan 30 16:19:51 2009 -0500
summary:     Bug 471317. Remove duplicate '/' in hg urls. r=me

Consistent naming of hg links:

comparing with ssh://hg.mozilla.org/build/buildbot-configs
searching for changes
changeset:   713:c812819ea819
tag:         tip
user:        Philippe M. Chiasson <[e-mail]>
date:        Fri Jan 30 16:26:31 2009 -0500
summary:     Bug 471317. Keep mozilla hg links consistently named. r=me

Buildbot master reloaded.

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> While there, the box names on that page should be unified too:
> after either '* comm-central *' or '* comm-central mozilla-central *'.

TB/m-c '* bloat build' still have this issue.

And TB/1.9.1 has '* comm-1.9.1 check' [too soon !?] and '* comm-central *' on all others.


(In reply to comment #9)
> Removed extra '/'s

http://hg.mozilla.org/build/buildbot-configs/rev/f2ad7012ff63

> Consistent naming of hg links:

http://hg.mozilla.org/build/buildbot-configs/rev/c812819ea819

Comment 11

[Mark Banner (:standard8)]

(In reply to comment #10)
> (In reply to comment #6)
> > While there, the box names on that page should be unified too:
> > after either '* comm-central *' or '* comm-central mozilla-central *'.
> 
> TB/m-c '* bloat build' still have this issue.

It is not an issue, it is just inconsistent naming. We are planning on renaming these boxes completely at an appropriate stage - they require a full source clobber to do this and we have been getting things stable first, it doesn't affect development in any way. We know this needs doing and will get around to it at the appropraite time.

> And TB/1.9.1 has '* comm-1.9.1 check' [too soon !?] and '* comm-central *' on
> all others.

It was not too soon, but it was easier to change the * check boxes because they are on a different buildbot master to the rest.

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to comment #11)

I filed bug 476548.

V.Fixed