Closed Bug 471368 Opened 15 years ago Closed 15 years ago

strange entity-names in newsblog.properties ("subsribe" instead of "subscribe") (Thunderbird part)

Categories

(MailNews Core :: Feed Reader, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: adriank, Assigned: yuenhoe)

References

Details

Attachments

(1 file)

subsribe-confirmFeedDeletionTitle=Remove Feed
subsribe-confirmFeedDeletion=Are you sure you want to unsubscribe from the feed: \n %S?
( http://hg.mozilla.org/comm-central/file/4382bcb7955e/mail/locales/en-US/chrome/messenger-newsblog/newsblog.properties#l20 )

Note the missing "c" in "subsribe-".
Sure, it's a silly-looking typo, but the link I would use instead is http://mxr.mozilla.org/l10n-central/search?string=subsribe - is it really worth fixing those two typos, at the expense of making localizers change 164 lines?
not 164, but 2, because there are only two strings per locale and product.

Regarding duping Bug 471369:
Doesn't the fact matter, that L10n-files are separate for each product? They are in mail/ and in suite/, but not in mailnews/
2 or 4 per person/team, depending on whether they are separate localizers for Tb and suite or not, but either way and no matter how many people it is that are doing it, it's still 164 changes, only 13 of which are currently untranslated, and thus would benefit from a less-confusing property name.

It's no skin off my nose, if you believe that 68 Tb localizers and 19 SM localizers (minus any overlap) all really want to have to add a letter to two lines for the possible benefit of future localizers, I'm just saying that it's not an obvious and unquestionable good thing to do, in a world where we have lots of other strings named useless things like 11091.

And no, it doesn't matter that the .properties files are different products, because there's only one shared line of code that reads them: if you change just the mail/ one, then the code that tries to use it with the old name just doesn't find the string; if you change the mail/ string and the code but not the suite/ string, then in SeaMonkey you get a blank dialog and an error.
I'm not saying that this is important, because it's not.
For users of L10n-tools that can sort by entity name (like the one I'm using), it looks a bit strange.
IMO we should fix this. Granted there's not much direct benefit to it right now, but correctness has an innate benefit all by itself and doing this right, might save us a broken dialog in the future, in case this code is ever rewritten or reorganized.

Adrian, can you put up a patch for this?


Oh and BTW, thanks Phil for that mxr-link in comment 2. Through that I found out that 14 more locales are currently working on a TB3 localization :-) Now I can contact them and ask them, if they need any help or guidance.
Not that big of a deal, but I agree with Simon. Trivial though in importance.
Severity: normal → trivial
Hi, I'd like to work on fixing this bug. Can it be assigned to me?
Sure.
Assignee: nobody → yuenhoe
Status: NEW → ASSIGNED
Attached patch fix for en_USSplinter Review
Fixed entity names for en_US version only for now.
Attachment #359984 - Flags: review?(philringnalda)
Perhaps sipaq would like a look at the patch as well?
Flags: wanted-thunderbird3?
Looks ok to me.
Comment on attachment 359984 [details] [diff] [review]
fix for en_US

r=me, except that both those lines in feed-subscriptions.js have trailing whitespace, which isn't your fault until you touch them, when it becomes your fault, and weird indentation three spaces too far, which again isn't your fault until you touch them and it becomes your fault (both already fixed locally, no need for another patch).
Attachment #359984 - Flags: review?(philringnalda) → review+
http://hg.mozilla.org/comm-central/rev/5b785063b020
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: wanted-thunderbird3?
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
Component: RSS → Feed Reader
Product: Thunderbird → MailNews Core
You need to log in before you can comment on or make changes to this bug.