47138 - [fix in hand]Some invalid units are not resulting in dropped declarations

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Hixie (not reading bugmail)]

Well, looks like the nsbeta2 testing is bringing out all the skeletons from our
collective cupboard... ;-)

Some properties, including margin, padding and border, and probably the various
border shorthands, are not getting dropped if they include invalid units.

For example, the following:
   DIV { border: red solid 3nm; }
...is resulting in a medium sized red border.
   
This is invalid per the CSS1 forward compatability parsing rules.

TO REPRODUCE:
   View the testcase or visit 
      http://www.webstandards.org/css/macie/errorhandlingdemo1.html
   ...which is a high profile testcase by the Web Standards Project.

EXPECTED RESULTS:
   *Any* declaration containing an invalid unit specifier or any other sort of
   syntax error should be dropped completely. Note: declaration = property/
   value pair, not the entire rule... ;-)

ACTUAL RESULTS:
   We seem to be silently dropping lengths with invalid units, and not dropping
   the rest of the rule. However, it seems to depend on where in the declaration
   the error occurs -- if it is at the beginning, then we ignore all of the
   numbers, for instance. See the testcase for details.

TESTED ON:
   Windows 2000 commercial build 6.0.17.2000072920.

Nominating for nsbeta3. This is a standards compliance error which is caught by
a testcase on a high profile test suite.

Comment 1

[Hixie (not reading bugmail)]

Attachment: Testcase showing problem in detail along with several cases that work.

Comment 2

[ekrock's old account (dead)]

Easy fix per pierre; [nsbeta3+].

Comment 3

[Pierre Saslawsky]

Attachment: patch

Comment 4

[Pierre Saslawsky]

Fix checked in nsCSSParser.cpp

Comment 5

[Hixie (not reading bugmail)]

VERIFIED FIXED on Windows 2000 and Linux Commercial Bits 2000090808.