471461 - Incorrect text displayed about groups when a bug is in a product which has only one group defined, with settings Mandatory/Mandatory

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

If a group is mandatory, even members of this group cannot remove the bug from that group, so this "warning" shouldn't be displayed to non-members. Also, if you belong to the group, all you get is the "Restrict Group Visibility:" label, with nothing displayed after it. This is confusing.

3.2 and tip are both affected. 3.0.6 is fine. This is a regression due to bug 374020.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Create the table + labels only if there is data to display.

Comment 2

[Teemu Mannermaa (:wicked)]

Comment on attachment 354756 [details] [diff] [review]
patch, v1

>Index: template/en/default/bug/edit.html.tmpl
>===================================================================
>-  <table class="bz_group_visibility_section">

On 3.2 branch this class doesn't exist so this first hunk didn't apply cleanly until I manually helped patch. Class was added in bug 214017. Remember to remove the class in the two table tags so it doesn't get added accidentally.

>+            <label id="bz_restrict_group_visibility_label"><b> Restrict Group Visibility</b>:</label>

Nit: Please, remove the unnecessary blank after <b> while you are here.

>+           [%+ 'checked="checked"' IF group.ison %]
>+           [%+ 'disabled="disabled"' IF NOT group.ingroup %]>

Nit: If you add these plusses then there's unnecessary newlines in the generated output. Please, remove them and add spaces before checked and disabled strings like it was in the old code.

Getting rid of the quoted quotes is a great change, though.

Comment 3

[Frédéric Buclin]

tip:

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.146; previous revision: 1.145
done

3.2:

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.125.2.17; previous revision: 1.125.2.16
done