Closed Bug 471547 Opened 12 years ago Closed 12 years ago

move PlacesDBUtils getters to avoid possible leaks

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: mak, Assigned: mak)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

we should move PlacesDBUtils getters in the constructor

see bug 469972 for the reasoning.
Attached patch patch v1.0Splinter Review
Attachment #354881 - Flags: review?(sdwilsh)
Comment on attachment 354881 [details] [diff] [review]
patch v1.0

>+  //////////////////////////////////////////////////////////////////////////////
>+  //// Smart getters
Make sure these lines don't go past 80 chars please

I'm not sure these were leaking before, but it could be possible.  r=sdwilsh
Attachment #354881 - Flags: review?(sdwilsh) → review+
http://hg.mozilla.org/mozilla-central/rev/37ac7732142f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1 → mozilla1.9.2a1
Attachment #354881 - Flags: approval1.9.1?
Comment on attachment 354881 [details] [diff] [review]
patch v1.0

Low risk, and I'd like to see this land on branch too.
Comment on attachment 354881 [details] [diff] [review]
patch v1.0

a191=beltzner
Attachment #354881 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.