Closed
Bug 471547
Opened 16 years ago
Closed 16 years ago
move PlacesDBUtils getters to avoid possible leaks
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: mak, Assigned: mak)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
3.75 KB,
patch
|
sdwilsh
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
we should move PlacesDBUtils getters in the constructor
see bug 469972 for the reasoning.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #354881 -
Flags: review?(sdwilsh)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 354881 [details] [diff] [review]
patch v1.0
>+ //////////////////////////////////////////////////////////////////////////////
>+ //// Smart getters
Make sure these lines don't go past 80 chars please
I'm not sure these were leaking before, but it could be possible. r=sdwilsh
Attachment #354881 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1 → mozilla1.9.2a1
|
|
||
Updated•16 years ago
|
Attachment #354881 -
Flags: approval1.9.1?
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 354881 [details] [diff] [review]
patch v1.0
Low risk, and I'd like to see this land on branch too.
|
||
Comment 5•16 years ago
|
||
Comment on attachment 354881 [details] [diff] [review]
patch v1.0
a191=beltzner
Attachment #354881 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Assignee | |
Comment 6•16 years ago
|
||
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•