471681 - Add a null check in CHBrowserView contentViewer

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

Attachment: guard against null

The stacks in 471409 are showing a null pointer deference in contentViewer, so presumably docShell is null. Given that we've never seen that before and 1Password is installed I'm not convinced that it's something that should legitimately be able to happen, but there's no reason not to add a guard there.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

FriscoFrog on the forum also was seeing crashes like bug 471409 on the forum; he had a mess of add-ons, but the common one with 471409 is 1Password.
http://forums.mozillazine.org/viewtopic.php?p=5351085#p5351085

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Bug 471941 shows this in 1.6.6, too (and 1Password was again in the mix); I think we want this in 1.6.7 if it will help.

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 354961 [details] [diff] [review]
guard against null

sr=pink

i wish we had a better grasp of why we're getting a null docShell here. Seems other things will break down the line.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk for Stuart.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the 18branch ahead of 1.6.7.