471700 - reftest for native-widgets fail for fennec, but pass in firefox

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I do not know if fennec supports native widgets or not, so this bug might be a work item for reftests.

When running reftests, I find some failures in layout/reftests/native-theme:
!= text-input-native.html text-input-nonnative.html
!= textarea-native.html textarea-nonnative.html
!= button-native.html button-nonnative.html
!= combobox-native.html combobox-nonnative.html
!= listbox-native.html listbox-nonnative.html
!= radio-native.html radio-nonnative.html
!= checkbox-native.html checkbox-nonnative.html

These are the only tests that fail in this reftest directory.  If I compare them as ==, they all pass.  This indicates that we are using the same widgets for native vs. nonnative.

This behavior is the same on both desktop linux version of fennec and maemo fennec.

Please advise if this is something to fix/add to fennec or something to work out with the reftests.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

we disable native theming here:
http://mxr.mozilla.org/mobile-browser/source/app/mobile.js#73

So I think this behavior is to be expected.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

native-widgets are turned off on fennec for performance reasons.  This is done
with a user_pref.  I verified these tests pass if we turn them on.  It looks
like we will be using non-native widgets for the 1.0 release, so this needs to
be a reftest workitem.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch for 192

This patch adds a "nativeTheme" boolean to the reftest sandbox. The flag can be checked in test manifests.

The patch also adds "skip_if(!nativeTheme)" to the problematic tests for Mobile

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

If this idea is sound, I'll make a mozilla-central patch too.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

from looking at this, this seems like the cleanest approach vs comparing chip architecture or looking for cross compilation.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 429733 [details] [diff] [review]
patch for 192

r=dbaron with three changes:

 (1) please call the object on the sandbox nativeThemePref rather than nativeTheme, since native theming can be disabled for other reasons other than the pref

 (2) use fails-if rather than skip-if (since we really only want to skip-if for tests that crash), and...

 (3) don't mark the == tests with anything, since they should still be passing.  It's only the != tests that should need fails-if.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed m-192:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/67e821c356b7

pushed m-c:
http://hg.mozilla.org/mozilla-central/rev/4180454f836e