Last Comment Bug 471722 - Plaintext editor redo handling code looks for incorrect type of bogus node
: Plaintext editor redo handling code looks for incorrect type of bogus node
Status: RESOLVED FIXED
[fixed1.9.1b3]
: fixed1.9.1
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla1.9.2a1
Assigned To: Graeme McCutcheon [:graememcc]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-31 12:44 PST by Graeme McCutcheon [:graememcc]
Modified: 2010-02-19 04:27 PST (History)
4 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Trivial fix (1.21 KB, patch)
2008-12-31 12:44 PST, Graeme McCutcheon [:graememcc]
peterv: review+
peterv: superreview+
Details | Diff | Splinter Review
Patch with possible mochitest (8.51 KB, patch)
2009-01-05 15:16 PST, Graeme McCutcheon [:graememcc]
no flags Details | Diff | Splinter Review
hg export for checkin [Checkin: Comment 6] (1.47 KB, patch)
2009-02-06 14:24 PST, Graeme McCutcheon [:graememcc]
no flags Details | Diff | Splinter Review
Mochitest (7.31 KB, patch)
2009-02-06 14:39 PST, Graeme McCutcheon [:graememcc]
peterv: review+
Details | Diff | Splinter Review
[Test] hg export for checkin [Checkin: Comment 8] (7.62 KB, patch)
2009-02-13 14:16 PST, Graeme McCutcheon [:graememcc]
no flags Details | Diff | Splinter Review
Combined patch for branch (8.78 KB, patch)
2009-02-14 15:25 PST, Graeme McCutcheon [:graememcc]
dbaron: approval1.9.1+
Details | Diff | Splinter Review
hg export for branch checkin [Checkin: Comment 12] (8.79 KB, patch)
2009-02-26 05:07 PST, Graeme McCutcheon [:graememcc]
no flags Details | Diff | Splinter Review

Description Graeme McCutcheon [:graememcc] 2008-12-31 12:44:24 PST
Created attachment 354977 [details] [diff] [review]
Trivial fix

From http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/editor/libeditor/text/nsTextEditRules.cpp&rev=HEAD&mark=1.211, revision 1.73 (which seems to correspond to bug 16905) the "bogus node" type was changed from a <div> to <br>.

When checking to see if a bogus node reappeared after redo, we're still looking for divs...
Comment 1 Peter Van der Beken [:peterv] - away till Aug 1st 2009-01-05 12:54:05 PST
Comment on attachment 354977 [details] [diff] [review]
Trivial fix

Sigh. I guess we don't really know how to test this?
Comment 2 Graeme McCutcheon [:graememcc] 2009-01-05 15:16:14 PST
Created attachment 355475 [details] [diff] [review]
Patch with possible mochitest

Would something like this be a suitable test?

It fails against current trunk, after the redo, the textbox's value = "\n" rather than "".
Comment 3 Graeme McCutcheon [:graememcc] 2009-01-07 13:29:13 PST
Comment on attachment 355475 [details] [diff] [review]
Patch with possible mochitest

Er, the second patch shouldn't need sr, as I already have it from the first patch, and this is just a review request for the test.
Comment 4 Graeme McCutcheon [:graememcc] 2009-02-06 14:24:31 PST
Created attachment 360975 [details] [diff] [review]
hg export for checkin
[Checkin: Comment 6]

Might as well try to get the fix in for baking. The test can follow.
Comment 5 Graeme McCutcheon [:graememcc] 2009-02-06 14:39:46 PST
Created attachment 360977 [details] [diff] [review]
Mochitest
Comment 6 Dão Gottwald [:dao] 2009-02-07 03:27:47 PST
http://hg.mozilla.org/mozilla-central/rev/6ebf4afe67d2
Comment 7 Graeme McCutcheon [:graememcc] 2009-02-13 14:16:29 PST
Created attachment 362309 [details] [diff] [review]
[Test] hg export for checkin
[Checkin: Comment 8]
Comment 8 Serge Gautherie (:sgautherie) 2009-02-14 11:40:07 PST
Comment on attachment 362309 [details] [diff] [review]
[Test] hg export for checkin
[Checkin: Comment 8]


http://hg.mozilla.org/mozilla-central/rev/e6daa019b2ca
Comment 9 Graeme McCutcheon [:graememcc] 2009-02-14 15:25:15 PST
Created attachment 362432 [details] [diff] [review]
Combined patch for branch

Requesting approval - very minor fix to correct the existing logic. Fixes a case where "redo" in textboxes has been broken since 1999!
Comment 10 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2009-02-25 17:01:33 PST
Comment on attachment 362432 [details] [diff] [review]
Combined patch for branch

a1.9.1=dbaron
Comment 11 Graeme McCutcheon [:graememcc] 2009-02-26 05:07:37 PST
Created attachment 364307 [details] [diff] [review]
hg export for branch checkin
[Checkin: Comment 12]
Comment 12 Serge Gautherie (:sgautherie) 2009-02-26 09:17:11 PST
Comment on attachment 364307 [details] [diff] [review]
hg export for branch checkin
[Checkin: Comment 12]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fd629d7e3122
Comment 13 Henri Sivonen (:hsivonen) (Not doing reviews or reading bugmail until 2016-08-01) 2010-02-19 04:27:05 PST
The test case for this bug has a bogus </head> tag in place of </title>. See bug 546256.

Note You need to log in before you can comment on or make changes to this bug.