Plaintext editor redo handling code looks for incorrect type of bogus node

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Core
Editor
RESOLVED FIXED
9 years ago
7 years ago

People

(Reporter: graememcc, Assigned: graememcc)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.2a1
fixed1.9.1
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed1.9.1b3])

Attachments

(3 attachments, 4 obsolete attachments)

(Assignee)

Description

9 years ago
Created attachment 354977 [details] [diff] [review]
Trivial fix

From http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/editor/libeditor/text/nsTextEditRules.cpp&rev=HEAD&mark=1.211, revision 1.73 (which seems to correspond to bug 16905) the "bogus node" type was changed from a <div> to <br>.

When checking to see if a bogus node reappeared after redo, we're still looking for divs...
Attachment #354977 - Flags: superreview?(peterv)
Attachment #354977 - Flags: review?(peterv)
Comment on attachment 354977 [details] [diff] [review]
Trivial fix

Sigh. I guess we don't really know how to test this?
Attachment #354977 - Flags: superreview?(peterv)
Attachment #354977 - Flags: superreview+
Attachment #354977 - Flags: review?(peterv)
Attachment #354977 - Flags: review+
(Assignee)

Comment 2

9 years ago
Created attachment 355475 [details] [diff] [review]
Patch with possible mochitest

Would something like this be a suitable test?

It fails against current trunk, after the redo, the textbox's value = "\n" rather than "".
Attachment #355475 - Flags: superreview?(peterv)
Attachment #355475 - Flags: review?(peterv)
(Assignee)

Comment 3

9 years ago
Comment on attachment 355475 [details] [diff] [review]
Patch with possible mochitest

Er, the second patch shouldn't need sr, as I already have it from the first patch, and this is just a review request for the test.
Attachment #355475 - Flags: superreview?(peterv)
(Assignee)

Comment 4

9 years ago
Created attachment 360975 [details] [diff] [review]
hg export for checkin
[Checkin: Comment 6]

Might as well try to get the fix in for baking. The test can follow.
Assignee: nobody → graememcc_firefox
Status: NEW → ASSIGNED
(Assignee)

Updated

9 years ago
Attachment #360975 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Whiteboard: Please checkin "hg export for checkin"
(Assignee)

Comment 5

9 years ago
Created attachment 360977 [details] [diff] [review]
Mochitest
Attachment #355475 - Attachment is obsolete: true
Attachment #360977 - Flags: review?(peterv)
Attachment #355475 - Flags: review?(peterv)

Updated

9 years ago
Attachment #360975 - Attachment is patch: true
http://hg.mozilla.org/mozilla-central/rev/6ebf4afe67d2
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: Please checkin "hg export for checkin"
Target Milestone: --- → mozilla1.9.2a1
Attachment #360977 - Flags: review?(peterv) → review+
(Assignee)

Comment 7

9 years ago
Created attachment 362309 [details] [diff] [review]
[Test] hg export for checkin
[Checkin: Comment 8]
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Whiteboard: please check in mochitest patch
Attachment #360975 - Attachment description: hg export for checkin → hg export for checkin [Checkin: Comment 6]
Attachment #354977 - Attachment is obsolete: true
Attachment #360977 - Attachment is obsolete: true
Comment on attachment 362309 [details] [diff] [review]
[Test] hg export for checkin
[Checkin: Comment 8]


http://hg.mozilla.org/mozilla-central/rev/e6daa019b2ca
Attachment #362309 - Attachment description: [Test] hg export for checkin → [Test] hg export for checkin [Checkin: Comment 8]
Flags: in-testsuite? → in-testsuite+
Keywords: checkin-needed
Whiteboard: please check in mochitest patch
(Assignee)

Comment 9

9 years ago
Created attachment 362432 [details] [diff] [review]
Combined patch for branch

Requesting approval - very minor fix to correct the existing logic. Fixes a case where "redo" in textboxes has been broken since 1999!
Attachment #362432 - Flags: approval1.9.1?
Attachment #362432 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 362432 [details] [diff] [review]
Combined patch for branch

a1.9.1=dbaron
(Assignee)

Comment 11

8 years ago
Created attachment 364307 [details] [diff] [review]
hg export for branch checkin
[Checkin: Comment 12]
Attachment #362432 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Whiteboard: Please checkin branch patch to 1.9.1
Comment on attachment 364307 [details] [diff] [review]
hg export for branch checkin
[Checkin: Comment 12]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fd629d7e3122
Attachment #364307 - Attachment description: hg export for branch checkin → hg export for branch checkin [Checkin: Comment 12]
Keywords: checkin-needed → fixed1.9.1
Whiteboard: Please checkin branch patch to 1.9.1 → [fixed1.9.1b3]
The test case for this bug has a bogus </head> tag in place of </title>. See bug 546256.
You need to log in before you can comment on or make changes to this bug.